Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the binary path of Chrome to wpt run in CI #10064

Merged
merged 2 commits into from Mar 16, 2018

Conversation

Projects
None yet
4 participants
@Hexcles
Copy link
Member

Hexcles commented Mar 16, 2018

ChromeDriver doesn't honor PATH and uses /opt/google/chrome/chrome by
default (which is usually the stable channel), so we need to explicitly
pass the desired binary path to wpt run (which in turn passes to
chromedriver via capabilities) in Travis CI (both stability check and
infrastructure test). This fixes #9979 and is one more step closer to #9932.

This PR also fixes a bug introduced in #9391. Due to the issue above, Chrome was disabled in infra integration tests, so the bug wasn't caught back then.


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Mar 16, 2018

@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jgraham Mar 16, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 16, 2018

Build PASSED

Started: 2018-03-16 16:51:02
Finished: 2018-03-16 17:01:08

View more information about this build on:

@Hexcles Hexcles force-pushed the fix-chrome-ci branch from 0bcfef0 to 3b96236 Mar 16, 2018

for PRODUCT in "${PRODUCTS[@]}"; do
if [ "$PRODUCT" != "firefox" ]; then
# Firefox is expected to work using pref settings for DNS
# Don't adjust the hostnames in that case to ensure this keeps working
hosts_fixup
fi
if [ "$PRODUCT" == "chrome" ]; then
install_chrome dev
test_infrastructure $(install_chrome dev)

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 16, 2018

Contributor

This seems to be getting called as:

test_infrastructure /usr/bin/google-chrome-stable Selecting previously unselected package google-chrome-unstable. '(Reading' database ... 93729 files and directories currently 'installed.)' Preparing to unpack google-chrome-unstable_current_amd64.deb ... Unpacking google-chrome-unstable '(66.0.3359.26-1)' ... Setting up google-chrome-unstable '(66.0.3359.26-1)' ... update-alternatives: using /usr/bin/google-chrome-unstable to provide /usr/bin/google-chrome '(google-chrome)' in auto mode Processing triggers for mime-support '(3.54ubuntu1.1)' ... Processing triggers for man-db '(2.6.7.1-1ubuntu1)' ... /usr/bin/google-chrome-unstable

This obviously doesn't work. :)

Pass the binary path of Chrome to wpt run in CI
ChromeDriver doesn't honor PATH and uses /opt/google/chrome/chrome by
default (which is usually the stable channel), so we need to explicitly
pass the desired binary path to wpt run (which in turn passes to
chromedriver via capabilities) in Travis CI (both stability check and
infrastructure test).

@Hexcles Hexcles force-pushed the fix-chrome-ci branch from 3b96236 to 2a0948b Mar 16, 2018

@Hexcles

This comment has been minimized.

Copy link
Member Author

Hexcles commented Mar 16, 2018

Looks like I fixed the binary path issue.

cc @kereliuk to take a look at the WebDriver error.

@@ -88,7 +88,7 @@ def close_old_windows(self):
for handle in handles:
try:
self.webdriver.switch_to_window(handle)
self.webdriver.close_window()
self.webdriver.close()

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 16, 2018

Contributor

This fixes a regression from 517c2ff (#9391).

@Hexcles Hexcles merged commit bb066ef into master Mar 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Hexcles Hexcles deleted the fix-chrome-ci branch Mar 16, 2018

Hexcles added a commit that referenced this pull request Mar 16, 2018

No longer allow Chrome stability check to fail
After #10064, Chrome jobs run successfully on Travis, so we can turn the
stability check back on.

Fixes #9932.

Hexcles added a commit that referenced this pull request Mar 20, 2018

No longer allow Chrome stability check to fail
After #10064, Chrome jobs run successfully on Travis, so we can turn the
stability check back on.

Fixes #9932.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.