Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "rename generic-sensor directory as sensors" #10068

Merged
merged 1 commit into from Mar 21, 2018

Conversation

@Honry
Copy link
Contributor

Honry commented Mar 16, 2018

@foolip, I still think we should revert the commit to prevent breaking the test suite link from its corresponding spec documentations(spec, wiki, WG charter) before we reach a consensus on the naming policy(#9937).

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 16, 2018

Build PASSED

Started: 2018-03-16 07:38:32
Finished: 2018-03-16 08:14:01

View more information about this build on:

@alexshalamov

This comment has been minimized.

Copy link

alexshalamov commented Mar 20, 2018

@Honry this looks like a change related to wpt infra, I'm not sure why folder is renamed back and forth. I would be happy to review functional changes, however, this change should be reviewed by someone else.

@foolip

foolip approved these changes Mar 20, 2018

@Honry

This comment has been minimized.

Copy link
Contributor Author

Honry commented Mar 21, 2018

Thanks, @alexshalamov, @foolip. Merging it...

@Honry Honry merged commit 66e0742 into web-platform-tests:master Mar 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Honry Honry deleted the Honry:revert-rename-generic-sensor branch Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.