Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory of last SDP offer/answer created #10075

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 16, 2018

This adds internal slots "LastOffer" and "LastAnswer", and uses
those to check that SetLocalDescription uses an unchanged SDP offer/answer.

Because modification of SDP is suspected to be used in a number of places,
this change only rejects SDP with modified fingerprints (which would fail
anyway), but merely counts the usage for other modifications.

Bug: chromium:823036
Change-Id: I0c978d5ff3e63b0afab3ec02334c57a5aaa94cdd
Reviewed-on: https://chromium-review.googlesource.com/966441
Commit-Queue: Harald Alvestrand hta@chromium.org
Reviewed-by: Henrik Boström hbos@chromium.org
Reviewed-by: Kentaro Hara haraken@chromium.org
Reviewed-by: Tommi tommi@chromium.org
Cr-Commit-Position: refs/heads/master@{#545175}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 16, 2018

Build PASSED

Started: 2018-03-22 19:00:43
Finished: 2018-03-22 19:06:30

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-966441 branch 14 times, most recently from ca9268d to 6f387d4 Mar 16, 2018

Add memory of last SDP offer/answer created
This adds internal slots "LastOffer" and "LastAnswer", and uses
those to check that SetLocalDescription uses an unchanged SDP offer/answer.

Because modification of SDP is suspected to be used in a number of places,
this change only rejects SDP with modified fingerprints (which would fail
anyway), but merely counts the usage for other modifications.

Bug: chromium:823036
Change-Id: I0c978d5ff3e63b0afab3ec02334c57a5aaa94cdd
Reviewed-on: https://chromium-review.googlesource.com/966441
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545175}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-966441 branch from 6f387d4 to a50b8da Mar 22, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e48a42f into master Mar 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-966441 branch Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.