Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in a resource file name (#9986) #10077

Merged
merged 1 commit into from Mar 19, 2018

Conversation

@Hexcles
Copy link
Member

Hexcles commented Mar 16, 2018

No description provided.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 16, 2018

Build ERRORED

Started: 2018-03-16 20:38:33
Finished: 2018-03-16 20:47:01

Failing Jobs

  • firefox:nightly
  • chrome:dev

Unstable Results

Browser: "Firefox Nightly"

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/resource-timing/resource_initiator_types.html   OK: 10
  http://web-platform.test:8000/fonts/Ahem.ttf?id=n1 is expected to have initiatorType css FAIL: 10
assert_equals: http://web-platform.test:8000/fonts/Ahem.ttf?id=n1 is expected to have initiatorType css expected "css" but got "other"
  http://web-platform.test:8000/fonts/Ahem.ttf is expected to have initiatorType css FAIL: 10
assert_equals: http://web-platform.test:8000/fonts/Ahem.ttf is expected to have initiatorType css expected "css" but got "other"
  http://web-platform.test:8000/media/test.mp4?id=video-src is expected to have initiatorType video FAIL: 10
assert_equals: http://web-platform.test:8000/media/test.mp4?id=video-src is expected to have initiatorType video expected "video" but got "other"
  http://web-platform.test:8000/media/test.ogv?id=video-source is expected to have initiatorType source FAIL: 10
assert_equals: http://web-platform.test:8000/media/test.ogv?id=video-source is expected to have initiatorType source expected "source" but got "other"
  http://web-platform.test:8000/resource-timing/resources/blank_page_green.htm?id=frame is expected to have initiatorType frame PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blank_page_green.htm is expected to have initiatorType iframe PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=1 is expected to have initiatorType css PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=2 is expected to have initiatorType css PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=async_xhr is expected to have initiatorType xmlhttprequest PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=body is expected to have initiatorType body FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/blue.png?id=body is expected to have initiatorType body expected "body" but got "css"
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=cursor is expected to have initiatorType css PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=input is expected to have initiatorType input PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=n1 is expected to have initiatorType css PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=object is expected to have initiatorType object PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=picture-99x-img-src is expected to have initiatorType img PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=picture-img-srcset is expected to have initiatorType img PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=picture-notsupported-img is expected to have initiatorType img PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=picture-source is expected to have initiatorType source FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/blue.png?id=picture-source is expected to have initiatorType source expected "source" but got "img"
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=svg-image is expected to have initiatorType image PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=video-poster is expected to have initiatorType video FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/blue.png?id=video-poster is expected to have initiatorType video expected "video" but got "img"
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-ogg is expected to have initiatorType source FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-ogg is expected to have initiatorType source expected "source" but got "other"
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-wav is expected to have initiatorType source FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-wav is expected to have initiatorType source expected "source" but got "other"
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-src is expected to have initiatorType audio FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-src is expected to have initiatorType audio expected "audio" but got "other"
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=beacon is expected to have initiatorType beacon FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/empty.py?id=beacon is expected to have initiatorType beacon expected "beacon" but got "other"
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=fetch is expected to have initiatorType fetch PASS: 10
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=video-track is expected to have initiatorType track FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/empty.py?id=video-track is expected to have initiatorType track expected "track" but got "other"
  http://web-platform.test:8000/resource-timing/resources/empty_script.js is expected to have initiatorType script PASS: 10
  http://web-platform.test:8000/resource-timing/resources/eventsource.py?id=eventsource is expected to have initiatorType eventsource FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/eventsource.py?id=eventsource is expected to have initiatorType eventsource expected "eventsource" but got "other"
  http://web-platform.test:8000/resource-timing/resources/nested.css?id=prefetch is expected to have initiatorType link FAIL: 9
assert_equals: http://web-platform.test:8000/resource-timing/resources/nested.css?id=prefetch is expected to have initiatorType link expected "link" but got "other"
  http://web-platform.test:8000/resource-timing/resources/nested.css?id=preload is expected to have initiatorType link FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/nested.css?id=preload is expected to have initiatorType link expected "link" but got "other"
  http://web-platform.test:8000/resource-timing/resources/nested.css is expected to have initiatorType link PASS: 10
  http://web-platform.test:8000/resource-timing/resources/resource_timing_test0.css?id=embed is expected to have initiatorType embed PASS: 10
  http://web-platform.test:8000/resource-timing/resources/resource_timing_test0.css?id=n1 is expected to have initiatorType css PASS: 10
  http://web-platform.test:8000/resource-timing/resources/resource_timing_test0.png?id=srcset-srcset is expected to have initiatorType img PASS: 10
  http://web-platform.test:8000/resource-timing/resources/resource_timing_test0.png is expected to have initiatorType img PASS: 10

Browser: "Chrome Dev" (failures allowed)

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/resource-timing/resource_initiator_types.html   OK: 10
  http://web-platform.test:8000/fonts/Ahem.ttf?id=n1 is expected to have initiatorType css PASS: 10
  http://web-platform.test:8000/fonts/Ahem.ttf is expected to have initiatorType css PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blank_page_green.htm?id=frame is expected to have initiatorType frame PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blank_page_green.htm is expected to have initiatorType iframe PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=1 is expected to have initiatorType css PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=2 is expected to have initiatorType css PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=async_xhr is expected to have initiatorType xmlhttprequest PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=body is expected to have initiatorType body PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=cursor is expected to have initiatorType css PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=input is expected to have initiatorType input PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=n1 is expected to have initiatorType css PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=object is expected to have initiatorType object PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=picture-99x-img-src is expected to have initiatorType img PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=picture-img-srcset is expected to have initiatorType img PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=picture-notsupported-img is expected to have initiatorType img PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=picture-source is expected to have initiatorType source FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/blue.png?id=picture-source is expected to have initiatorType source expected "source" but got "img"
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=svg-image is expected to have initiatorType image PASS: 10
  http://web-platform.test:8000/resource-timing/resources/blue.png?id=video-poster is expected to have initiatorType video PASS: 10
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-mpeg is expected to have initiatorType source FAIL: 2
assert_equals: http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-mpeg is expected to have initiatorType source expected "source" but got ""
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-ogg is expected to have initiatorType source FAIL: 1
assert_equals: http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-ogg is expected to have initiatorType source expected "source" but got ""
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-wav is expected to have initiatorType source FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-source-wav is expected to have initiatorType source expected "source" but got ""
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-src is expected to have initiatorType audio FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/empty.py?id=audio-src is expected to have initiatorType audio expected "audio" but got ""
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=beacon is expected to have initiatorType beacon PASS: 10
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=fetch is expected to have initiatorType fetch FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/empty.py?id=fetch is expected to have initiatorType fetch expected "fetch" but got ""
  http://web-platform.test:8000/resource-timing/resources/empty.py?id=video-track is expected to have initiatorType track FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/empty.py?id=video-track is expected to have initiatorType track expected "track" but got "texttrack"
  http://web-platform.test:8000/resource-timing/resources/empty_script.js is expected to have initiatorType script PASS: 10
  http://web-platform.test:8000/resource-timing/resources/eventsource.py?id=eventsource is expected to have initiatorType eventsource FAIL: 10
assert_equals: http://web-platform.test:8000/resource-timing/resources/eventsource.py?id=eventsource is expected to have initiatorType eventsource expected "eventsource" but got ""
  http://web-platform.test:8000/resource-timing/resources/nested.css?id=prefetch is expected to have initiatorType link PASS: 10
  http://web-platform.test:8000/resource-timing/resources/nested.css?id=preload is expected to have initiatorType link PASS: 10
  http://web-platform.test:8000/resource-timing/resources/nested.css is expected to have initiatorType link PASS: 10
  http://web-platform.test:8000/resource-timing/resources/resource_timing_test0.css?id=embed is expected to have initiatorType embed PASS: 10
  http://web-platform.test:8000/resource-timing/resources/resource_timing_test0.css?id=n1 is expected to have initiatorType css PASS: 10
  http://web-platform.test:8000/resource-timing/resources/resource_timing_test0.png?id=srcset-srcset is expected to have initiatorType img PASS: 10
  http://web-platform.test:8000/resource-timing/resources/resource_timing_test0.png is expected to have initiatorType img PASS: 10
@Hexcles

This comment has been minimized.

Copy link
Member Author

Hexcles commented Mar 16, 2018

Test Subtest Results Messages
/resource-timing/resource_initiator_types.html http://web-platform.test:8000/resource-timing/resources/nested.css?id=prefetch is expected to have initiatorType link FAIL: 6/10, MISSING: 4/10 assert_equals: http://web-platform.test:8000/resource-timing/resources/nested.css?id=prefetch is expected to have initiatorType link expected "link" but got "other"

Looks like the test is very flaky. How did #9986 pass Travis?

I'm not familiar with Resource Timing, but wonder if there's any guarantees on the ordering of entries?

@nicjansma

This comment has been minimized.

Copy link
Contributor

nicjansma commented Mar 16, 2018

Thanks @Hexcles, this change looks great.

Unfortunately none of the browsers actually pass these tests today (each has a few bugs to address).

@Hexcles

This comment has been minimized.

Copy link
Member Author

Hexcles commented Mar 16, 2018

@nicjansma the problem is less about failures, but more about flakes.

We are totally fine with all browsers failing a test, but we don't want a test to produce flaky results (e.g. adding subtests out of order, randomly missing some subtests...).

As you can see from my comment above, 4 out of 10 times a subtest (nested.css?id=prefetch) is missing in Firefox. Is there any way to stabilize the test?

@igrigorik
Copy link
Member

igrigorik left a comment

LGTM for the typo fix.

We should split the flaky test discussion into a separate thread. :)

@gsnedders gsnedders merged commit 5dee619 into master Mar 19, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@gsnedders gsnedders deleted the fix-up-9986 branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.