Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of last web-platform.test, make host_ip always present #10078

Merged
merged 4 commits into from Mar 19, 2018

Conversation

Projects
None yet
4 participants
@gsnedders
Copy link
Contributor

gsnedders commented Mar 16, 2018

This change is Reviewable

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 16, 2018

Build PASSED

Started: 2018-03-19 15:39:50
Finished: 2018-03-19 15:56:02

View more information about this build on:

@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Mar 19, 2018

Reviewed 3 of 3 files at r1, 3 of 3 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


tools/serve/serve.py, line 679 at r1 (raw file):

    config_["bind_address"] = bind_address
    if config.get("host_ip", None) is None:
        config_["host_ip"] = host

This seems very confusing. I don't know what the better option is, but I'm pretty sure this is going to cause trouble.


Comments from Reviewable

@@ -168,7 +168,8 @@ def __init__(self, server_address, request_handler_cls,
Server.config = config
else:
self.logger.debug("Using default configuration")
Server.config = {"host": server_address[0],
Server.config = {"browser_host": server_address[0],

This comment has been minimized.

Copy link
@jgraham

jgraham Mar 19, 2018

Contributor

This doesn't seem very meaningful, to put browser_host and server_host and set them to o the same value.

@gsnedders gsnedders force-pushed the gsnedders:host_ip_always branch from dcb0aa7 to d2bf9c1 Mar 19, 2018

@gsnedders gsnedders merged commit f281dad into web-platform-tests:master Mar 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the gsnedders:host_ip_always branch Mar 19, 2018

aarongable pushed a commit to chromium/chromium that referenced this pull request Apr 5, 2018

Roll in new version of WPT tools
This roll is mainly to include
web-platform-tests/wpt#10323, which fixes a bug
that `wpt manifest` would fail when the local manifest is invalid.

wpt.config.json is changed to accomodate:
web-platform-tests/wpt#9998
web-platform-tests/wpt#10078

Bug: 822041
Change-Id: I074afd90e32db299fc6f58b870f9b72576fab225
Reviewed-on: https://chromium-review.googlesource.com/997764
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548584}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.