Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1443492] Flush the document, not the shell, in cross-doc getComputedStyle situations. #10079

Merged
merged 1 commit into from Mar 19, 2018

Conversation

Projects
None yet
3 participants
@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Mar 16, 2018

We flushed the style of the original doc, but not layout, and thus the iframe
resize wasn't noticed, and the style flush on the child presShell wasn't
sufficient.

Do a style flush on the child document instead, so that it flushes layout on the
parent document too if needed.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1443492
gecko-commit: 9cbafe1855ccac5fd2f0c2e549e830a66a72f84f
gecko-integration-branch: mozilla-inbound
gecko-reviewers: dbaron

Flush the document, not the shell, in cross-doc getComputedStyle situ…
…ations.

We flushed the style of the original doc, but not layout, and thus the iframe
resize wasn't noticed, and the style flush on the child presShell wasn't
sufficient.

Do a style flush on the child document instead, so that it flushes layout on the
parent document too if needed.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1443492
gecko-commit: 9cbafe1855ccac5fd2f0c2e549e830a66a72f84f
gecko-integration-branch: mozilla-inbound
gecko-reviewers: dbaron
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 16, 2018

Build PASSED

Started: 2018-03-16 17:20:56
Finished: 2018-03-16 17:35:44

View more information about this build on:

@moz-wptsync-bot moz-wptsync-bot merged commit e676f7b into master Mar 19, 2018

1 of 2 checks passed

upstream/gecko Landed on mozilla-central
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1443492 branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.