Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer allow Chrome stability check to fail #10082

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
5 participants
@Hexcles
Copy link
Member

Hexcles commented Mar 16, 2018

After #10064, Chrome jobs run successfully on Travis, so we can turn the
stability check back on.

Fixes #9932.

Note: I'm not planning to land this immediately. Just sending this out now, and I'll wait for some more Travis builds and see how they go next week.


This change is Reviewable

No longer allow Chrome stability check to fail
After #10064, Chrome jobs run successfully on Travis, so we can turn the
stability check back on.

Fixes #9932.

@Hexcles Hexcles requested a review from foolip Mar 16, 2018

@wpt-pr-bot wpt-pr-bot added the infra label Mar 16, 2018

@wpt-pr-bot wpt-pr-bot requested a review from jgraham Mar 16, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 16, 2018

Build PASSED

Started: 2018-03-16 21:22:08
Finished: 2018-03-16 21:26:28

View more information about this build on:

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Mar 16, 2018

Labelling this so I don't accidentally approve/merge it. :)

@foolip

foolip approved these changes Mar 20, 2018

Copy link
Contributor

foolip left a comment

LGTM to merge when it's a good idea.

@Hexcles

This comment has been minimized.

Copy link
Member Author

Hexcles commented Mar 20, 2018

Just examined the recent builds. I feel confident enough to flip the switch now.

@gsnedders @jgraham FYI I'm landing this. In the unlikely event that you see an unreasonable amount of false alarms caused by the Chrome stability job, feel free to revert this any time.

@Hexcles Hexcles merged commit 4d10320 into master Mar 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Hexcles Hexcles deleted the make-chrome-ci-blocking branch Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.