Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Add support for motion path properties. #10086

Merged
merged 1 commit into from Mar 19, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 19, 2018

This patch adds support for motion path properties. We had to modify
the computed style computation for values. Previously, we
parse a value as a CSSValuePair, but compute them to a
CSSValueList containing two items. This is very strange, so we just
compute to a CSSValuePair. Since both serialize to the same string,
this has no behavioural changes on CSSOM.

Bug: 820299
Change-Id: I2131055dad0785eb47ea2d2d89f00229f4376bae
Reviewed-on: https://chromium-review.googlesource.com/967915
Reviewed-by: nainar nainar@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#543975}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 19, 2018

Build PASSED

Started: 2018-03-19 05:47:52
Finished: 2018-03-19 05:55:16

View more information about this build on:

[css-typed-om] Add support for motion path properties.
This patch adds support for motion path properties. We had to modify
the computed style computation for <position> values. Previously, we
parse a <position> value as a CSSValuePair, but compute them to a
CSSValueList containing two items. This is very strange, so we just
compute to a CSSValuePair. Since both serialize to the same string,
this has no behavioural changes on CSSOM.

Bug: 820299
Change-Id: I2131055dad0785eb47ea2d2d89f00229f4376bae
Reviewed-on: https://chromium-review.googlesource.com/967915
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543975}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-967915 branch from 9ca37c6 to 2d56cd1 Mar 19, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 1f80be4 into master Mar 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-967915 branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.