Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user activation must survive postMessage() to call show() #10090

Merged
merged 2 commits into from Mar 21, 2018

Conversation

Projects
None yet
5 participants
@marcoscaceres
Copy link
Contributor

marcoscaceres commented Mar 19, 2018

Check that we can call pr.show() in an iframe via postMessage(), which
is triggered by user activation.

user activation survives postMessage()
Check that we can call pr.show() in an iframe via postMessage(), which
is triggered by user activation.
@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

marcoscaceres commented Mar 19, 2018

This passes in Chrome, but fails in Firefox ATM.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 19, 2018

Build PASSED

Started: 2018-03-19 06:06:14
Finished: 2018-03-19 06:11:49

View more information about this build on:

@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

marcoscaceres commented Mar 20, 2018

May help make progress on whatwg/html#1903 ?

@marcoscaceres marcoscaceres merged commit 92885ac into master Mar 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@marcoscaceres marcoscaceres deleted the user_activation_iframe branch Mar 21, 2018

@mnoorenberghe

This comment has been minimized.

Copy link
Contributor

mnoorenberghe commented Mar 21, 2018

On second thought… I think this is testing more than what's in the spec (correct me if I'm wrong) so I'm not sure the test is appropriate for now.
Update: Marcos pointed out that the 3rd bullet of "triggered by user activation" could allow this.

@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

marcoscaceres commented Mar 21, 2018

@domenic wrote the spec text in HTML, so he can confirm :)

@domenic

This comment has been minimized.

Copy link
Member

domenic commented Mar 21, 2018

Sorry, I'm on vacation until April :)

@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

marcoscaceres commented Mar 21, 2018

Sorry, I'm on vacation until April :)

Np! Enjoy! 🏖🏙

vinicius0197 added a commit to vinicius0197/web-platform-tests that referenced this pull request Mar 23, 2018

user activation must survive postMessage() to call show() (web-platfo…
…rm-tests#10090)

Check that we can call pr.show() in an iframe via postMessage(), which is triggered by user activation.

vinicius0197 added a commit to vinicius0197/web-platform-tests that referenced this pull request Mar 23, 2018

user activation must survive postMessage() to call show() (web-platfo…
…rm-tests#10090)

Check that we can call pr.show() in an iframe via postMessage(), which is triggered by user activation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.