Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scroll-snap-type: proximity #10115

Merged
merged 1 commit into from Mar 21, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 20, 2018

As specified in the spec, when the snap-container has scroll-snap-type:
proximity, we should only consider snap positions that are close to the
current scroll offset.
https://drafts.csswg.org/css-scroll-snap-1/#snap-strictness

Bug: 823820
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6312f98df421e303eb538f422ede39cea8dd5d38
Reviewed-on: https://chromium-review.googlesource.com/971466
Commit-Queue: Sandra Sun sunyunjia@chromium.org
Reviewed-by: Ali Juma ajuma@chromium.org
Reviewed-by: David Bokan bokan@chromium.org
Cr-Commit-Position: refs/heads/master@{#544783}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 20, 2018

Build PASSED

Started: 2018-03-21 19:01:59
Finished: 2018-03-21 19:10:35

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-971466 branch 2 times, most recently from 1cd75ed to fc81e7c Mar 21, 2018

Implement scroll-snap-type: proximity
As specified in the spec, when the snap-container has scroll-snap-type:
proximity, we should only consider snap positions that are close to the
current scroll offset.
https://drafts.csswg.org/css-scroll-snap-1/#snap-strictness

Bug: 823820
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6312f98df421e303eb538f422ede39cea8dd5d38
Reviewed-on: https://chromium-review.googlesource.com/971466
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544783}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-971466 branch from fc81e7c to 4b5d591 Mar 21, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit c6ed739 into master Mar 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-971466 branch Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.