Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix ci_resources_unittest (#10114) #10116

Merged
merged 1 commit into from Mar 21, 2018

Conversation

Projects
None yet
5 participants
@Hexcles
Copy link
Member

Hexcles commented Mar 20, 2018

The test wasn't running against the downloaded Firefox Nightly but
system Firefox instead, which is fixed by passing the binary path to
tox (which then passes it to pytest conftest.py).

The pip requirements should be managed by tox.


This change is Reviewable

Attempt to fix ci_resources_unittest
The test wasn't running against the downloaded Firefox Nightly but
system Firefox instead, which is fixed by passing the binary path to
tox (which then passes it to pytest conftest.py).

The pip requirements should be managed by tox.

@wpt-pr-bot wpt-pr-bot added the infra label Mar 20, 2018

@wpt-pr-bot wpt-pr-bot requested review from ayg, gsnedders and jgraham Mar 20, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 20, 2018

Build PASSED

Started: 2018-03-21 00:47:41
Finished: 2018-03-21 00:50:40

View more information about this build on:

./wpt install firefox browser --destination $HOME
./wpt install firefox webdriver --destination $HOME/firefox
export PATH=$HOME/firefox:$PATH

cd $WPT_ROOT/resources/test
tox
tox -- --binary=$HOME/browsers/firefox/firefox

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Mar 21, 2018

Contributor

The line above installs in $HOME/firefox - where does the browsers/ subdir come from?

This comment has been minimized.

Copy link
@Hexcles

Hexcles Mar 21, 2018

Author Member

This is installed in one more line above.

wpt install firefox browser installs the browser to DESTINATION/browsers/firefox

@jgraham jgraham merged commit 47c9322 into master Mar 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the fix-resources-unittest branch Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.