Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent false positives #10120

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
None yet
5 participants
@marcoscaceres
Copy link
Contributor

marcoscaceres commented Mar 21, 2018

No description provided.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 21, 2018

Build PASSED

Started: 2018-03-21 04:48:14
Finished: 2018-03-21 04:54:39

View more information about this build on:

@marcoscaceres marcoscaceres merged commit f5b48cf into master Mar 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@marcoscaceres marcoscaceres deleted the edge_false_positive branch Mar 22, 2018

@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

marcoscaceres commented Mar 22, 2018

So, um, I'm little embarrassed to admit that I thought Chrome had implemented requiring click on .show()... turns out, as of this test, not yet.

So we don't actually know if Chrome will be able to do the postMessage() either ☺️.

Oh hai, @rsolomakhin!

@rsolomakhin

This comment has been minimized.

Copy link
Contributor

rsolomakhin commented Mar 22, 2018

Hai, @marcoscaceres! We are waiting for .show() promise work to be finished before requiring user gesture for .show(). This avoid breaking some existing merchants.

@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

marcoscaceres commented Mar 23, 2018

@rsolomakhin sounds good. I know Chrome recently landed support for "triggered by user activation" surviving a promise.then(), but do you know if postMessage()? Stripe folks were asking, as their iframe is hidden, and it's the iframe that actually calls show().

@rsolomakhin

This comment has been minimized.

Copy link
Contributor

rsolomakhin commented Mar 23, 2018

@marcoscaceres: @mounirlamouri says it should work, but it's behind a flag at the moment.

@marcoscaceres

This comment has been minimized.

Copy link
Contributor Author

marcoscaceres commented Mar 23, 2018

Excellent, thanks for the update. If there is a bug I can cc myself on let me know. We’ll need both Firefox and Chrome to pass this test to get us out of CR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.