Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid] Fix testing-utils.js #10122

Merged
merged 1 commit into from Mar 21, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 21, 2018

We have been calling testGridTemplateColumnsRows() with
and without arrays.
Arrays are needed because the serialization of 2 tracks of the same size
can be "100px 100px" or "repeat(2, 100px)".
But in the rest of the cases we don't need an array,
so we call the method with a single value.
testGridTemplateColumnsRows() was not ready to support that,
and it wasn't actually checking anything in that case.

The patch modifies testing-utils.js, so it wraps values in an array
when required.
Now testGridTemplateColumnsRows() will be actually checking things.

Change-Id: I7e360677c391df74dedb474922bf5c04247141c5
Reviewed-on: https://chromium-review.googlesource.com/973063
Reviewed-by: Sergio Villar svillar@igalia.com
Commit-Queue: Manuel Rego Casasnovas rego@igalia.com
Cr-Commit-Position: refs/heads/master@{#544681}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 21, 2018

Build PASSED

Started: 2018-03-21 13:43:26
Finished: 2018-03-21 13:48:58

View more information about this build on:

[css-grid] Fix testing-utils.js
We have been calling testGridTemplateColumnsRows() with
and without arrays.
Arrays are needed because the serialization of 2 tracks of the same size
can be "100px 100px" or "repeat(2, 100px)".
But in the rest of the cases we don't need an array,
so we call the method with a single value.
testGridTemplateColumnsRows() was not ready to support that,
and it wasn't actually checking anything in that case.

The patch modifies testing-utils.js, so it wraps values in an array
when required.
Now testGridTemplateColumnsRows() will be actually checking things.

Change-Id: I7e360677c391df74dedb474922bf5c04247141c5
Reviewed-on: https://chromium-review.googlesource.com/973063
Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#544681}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-973063 branch from 4c0c20c to 14571a6 Mar 21, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 535e962 into master Mar 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-973063 branch Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.