Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MessagePort's close() detach #10123

Merged
merged 1 commit into from Apr 27, 2018

Conversation

Projects
None yet
5 participants
@annevk
Copy link
Member

annevk commented Mar 21, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 21, 2018

Build PASSED

Started: 2018-03-21 14:36:02
Finished: 2018-03-21 14:51:37

View more information about this build on:

c.port1.close();
assert_throws("DataCloneError", () => self.postMessage(null, "*", [c.port1]));
self.postMessage(null, "*", [c.port2]);
}, "close() detaches a MessageChannel (but not the one its entangled with)");
</script>

This comment has been minimized.

Copy link
@mkruisselbrink

mkruisselbrink Mar 21, 2018

Contributor

you'll want to at least update the "Message sent from transferred closed port should not arrive." test above, since that one won't be valid anymore. Not sure if there are other tests that assume/verify the previous behavior as well.

@annevk

This comment has been minimized.

Copy link
Member Author

annevk commented Apr 27, 2018

Good point. Firefox passes both these tests.

@annevk

This comment has been minimized.

Copy link
Member Author

annevk commented Apr 27, 2018

Hmm, seems @bakulf removed this test in #10309, time to rebase.

@annevk annevk force-pushed the annevk/messageport-close branch from 17df1aa to ab47c26 Apr 27, 2018

@annevk annevk requested a review from domenic Apr 27, 2018

@annevk annevk merged commit b51b155 into master Apr 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the annevk/messageport-close branch Apr 27, 2018

annevk added a commit to whatwg/html that referenced this pull request Apr 27, 2018

alice added a commit to alice/html that referenced this pull request Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.