Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python gitignore for directories. #10131

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
4 participants
@jgraham
Copy link
Contributor

jgraham commented Mar 21, 2018

For top level directories like _venv/ we were creating the regexp
^_venv/$, which we were then feeding paths like _venv/bin/foo which
it fails to match. Since we are matching against full paths, we
certainly want to allow matching _venv/* and probably also bare _venv,
so add a special case for paths with a trailing slash to allow these
options.


This change is Reviewable

Fix python gitignore for directories.
For top level directories like _venv/ we were creating the regexp
^\_venv/$, which we were then feeding paths like _venv/bin/foo which
it fails to match. Since we are matching against full paths, we
certainly want to allow matching _venv/* and probably also bare _venv,
so add a special case for paths with a trailing slash to allow these
options.

@wpt-pr-bot wpt-pr-bot added the infra label Mar 21, 2018

@wpt-pr-bot wpt-pr-bot requested a review from gsnedders Mar 21, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 21, 2018

Build PASSED

Started: 2018-03-21 22:15:41
Finished: 2018-03-21 22:29:44

View more information about this build on:

@gsnedders gsnedders merged commit 174f764 into master Mar 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the _venv_ignore branch Mar 23, 2018

@jgraham

This comment has been minimized.

Copy link
Contributor Author

jgraham commented Mar 23, 2018

Oh, I realised later that this is harmless, but not really right. I should have closed the PR. Anyway, I think it's at least harmless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.