Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CEReactions tests for HTMLButtonElement #10137

Merged
merged 3 commits into from Nov 26, 2018

Conversation

@xiaoyu3x
Copy link
Contributor

xiaoyu3x commented Mar 22, 2018

  • Verify attributes of HTMLButtonElement interface have CEReactions.
  • Adjust functions ‘testReflectAttribute’ and ‘testReflectAttributeWithContentValues’ in the reactions.js to compatible customized built-in element
Add CEReactions tests for HTMLButtonElement
- Verify attributes of HTMLButtonElement interface have CEReactions
- Adjust functions "testReflectAttribute" and "testReflectAttributeWithContentValues"
in the reactions.js to compatible customized built-in element

@xiaoyu3x xiaoyu3x force-pushed the xiaoyu3x:add-custom-element-button branch from 59781fb to f7b5d90 Mar 22, 2018

@xiaoyu3x xiaoyu3x changed the title Add CEReactions on HTMLButtonElement and update reaction.js Add CEReactions tests for HTMLButtonElement Mar 22, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 22, 2018

Build PASSED

Started: 2018-03-22 05:49:59
Finished: 2018-03-22 06:02:31

View more information about this build on:

Address @rniwa's comment and fix nit issue
- Expose and rename "testReflectAttrWithContentValuesAndParentNode" directly
- Fix nit: s/formNoValidate/formnovalidate
@rniwa

rniwa approved these changes Nov 26, 2018

Copy link
Contributor

rniwa left a comment

Great. Thanks for the test!

@rniwa rniwa merged commit 98103d8 into web-platform-tests:master Nov 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.