Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker: Allow dynamic import() on DedicatedWorkerGlobalScope #10139

Merged
merged 1 commit into from Mar 26, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 22, 2018

This CL allows dynamic import() on DedicatedWorkerGlobalScope and adds WPT
tests. Note that ES Modules on DedicatedWorker is an experimental feature behind
the runtime flag.

Design doc:
https://docs.google.com/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit#heading=h.637avx8i5qtn

Bug: 680046
Change-Id: I1f8fed5c319aab634f96bcfabeb3c95f5dc7d9a7
Reviewed-on: https://chromium-review.googlesource.com/970127
Commit-Queue: Hiroki Nakagawa nhiroki@chromium.org
Reviewed-by: Kouhei Ueno kouhei@chromium.org
Reviewed-by: Matt Falkenhagen falken@chromium.org
Reviewed-by: Makoto Shimazu shimazu@chromium.org
Cr-Commit-Position: refs/heads/master@{#545748}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 22, 2018

Build PASSED

Started: 2018-03-26 09:30:26
Finished: 2018-03-26 09:36:09

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-970127 branch 4 times, most recently from e9a96eb to 34212c2 Mar 22, 2018

Worker: Allow dynamic import() on DedicatedWorkerGlobalScope
This CL allows dynamic import() on DedicatedWorkerGlobalScope and adds WPT
tests. Note that ES Modules on DedicatedWorker is an experimental feature behind
the runtime flag.

Design doc:
https://docs.google.com/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit#heading=h.637avx8i5qtn

Bug: 680046
Change-Id: I1f8fed5c319aab634f96bcfabeb3c95f5dc7d9a7
Reviewed-on: https://chromium-review.googlesource.com/970127
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545748}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-970127 branch from 34212c2 to 7c96c90 Mar 26, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit e31f590 into master Mar 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-970127 branch Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.