Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip display:none options finding selectable options. #10146

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
3 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 22, 2018

This means we can also assume a null ComputedStyle on options means they
are display:none. That is a pre-requisite for fixing issue 822581.

Bug: 824754
Change-Id: Ia8a400ec8eed9ecb9a85d2c93c354841ad721492
Reviewed-on: https://chromium-review.googlesource.com/975604
Commit-Queue: Rune Lillesveen futhark@chromium.org
Reviewed-by: Kent Tamura tkent@chromium.org
Cr-Commit-Position: refs/heads/master@{#545443}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 22, 2018

Build PASSED

Started: 2018-03-23 15:03:49
Finished: 2018-03-23 15:09:20

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-975604 branch from 6855dcb to 7839fc2 Mar 23, 2018

Don't skip display:none options finding selectable options.
This means we can also assume a null ComputedStyle on options means they
are display:none. That is a pre-requisite for fixing issue 822581.

Bug: 824754
Change-Id: Ia8a400ec8eed9ecb9a85d2c93c354841ad721492
Reviewed-on: https://chromium-review.googlesource.com/975604
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545443}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-975604 branch from 7839fc2 to 89a7b39 Mar 23, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 2d1fd9e into master Mar 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-975604 branch Mar 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.