Don't skip display:none options finding selectable options. #10146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 22, 2018
Build PASSEDStarted: 2018-03-23 15:03:49 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-975604
branch
from
6855dcb
to
7839fc2
Compare
This means we can also assume a null ComputedStyle on options means they are display:none. That is a pre-requisite for fixing issue 822581. Bug: 824754 Change-Id: Ia8a400ec8eed9ecb9a85d2c93c354841ad721492 Reviewed-on: https://chromium-review.googlesource.com/975604 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#545443}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-975604
branch
from
7839fc2
to
89a7b39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we can also assume a null ComputedStyle on options means they
are display:none. That is a pre-requisite for fixing issue 822581.
Bug: 824754
Change-Id: Ia8a400ec8eed9ecb9a85d2c93c354841ad721492
Reviewed-on: https://chromium-review.googlesource.com/975604
Commit-Queue: Rune Lillesveen futhark@chromium.org
Reviewed-by: Kent Tamura tkent@chromium.org
Cr-Commit-Position: refs/heads/master@{#545443}