Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lint checking directories it shouldn't be #10147

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
5 participants
@Cactusmachete
Copy link
Contributor

Cactusmachete commented Mar 22, 2018

Lint earlier checked _venv/ and .git/ which it shouldn't be checking.


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Mar 22, 2018

@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jgraham Mar 22, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 22, 2018

Build PASSED

Started: 2018-03-22 21:39:27
Finished: 2018-03-22 21:58:07

View more information about this build on:

@Cactusmachete Cactusmachete changed the title Fixed lint checking directories it shouldn't be Fixed lint printing double and checking directories it shouldn't be Mar 22, 2018

@Cactusmachete Cactusmachete force-pushed the Cactusmachete:cactus3 branch from 7578a13 to cceb882 Mar 22, 2018

Cactusmachete
Fixed lint checking directories it shouldn't be
Lint earlier checked _venv/ and .git/ which it shouldn't be checking.

@Cactusmachete Cactusmachete force-pushed the Cactusmachete:cactus3 branch from cceb882 to 47e1e79 Mar 22, 2018

@Cactusmachete Cactusmachete changed the title Fixed lint printing double and checking directories it shouldn't be Fixed lint checking directories it shouldn't be Mar 22, 2018

@Hexcles

This comment has been minimized.

Copy link
Member

Hexcles commented Mar 22, 2018

@jgraham this looks like the same issue as your #10131

@jgraham
Copy link
Contributor

jgraham left a comment

I have a slightly bigger change that supercedes part of this patch, but I think this is right, so let's land it and do the rest as a followup.

Thanks for investigating!

@jgraham jgraham merged commit b705dc1 into web-platform-tests:master Mar 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Cactusmachete Cactusmachete deleted the Cactusmachete:cactus3 branch Mar 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.