Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client.postMessage to unloaded Client #10153

Conversation

Projects
None yet
4 participants
@jungkees
Copy link
Contributor

jungkees commented Mar 23, 2018

Client.postMessage to an unloaded Client object must throw an
"InvalidStateError" DOMException. (See https://w3c.github.io/ServiceWorker/#dom-client-postmessage.)
This adds a test for that requirement.

Related spec issue: w3c/ServiceWorker#1042.
Related spec PR: w3c/ServiceWorker#1274.

Jungkee Song
Client.postMessage to unloaded Client
Client.postMessage to an unloaded Client object must throw an
"InvalidStateError" DOMException. (See https://w3c.github.io/ServiceWorker/#dom-client-postmessage.)
This adds a test for that requirement.

Related spec issue: w3c/ServiceWorker#1042.
Related spec PR: w3c/ServiceWorker#1274.
@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 23, 2018

Build PASSED

Started: 2018-03-23 14:56:28
Finished: 2018-03-23 15:04:40

View more information about this build on:

Jungkee Song
@wanderview

This comment has been minimized.

Copy link
Contributor

wanderview commented Mar 23, 2018

Do we really want this behavior? Typically other postMessage() methods do not throw.

@wanderview

This comment has been minimized.

Copy link
Contributor

wanderview commented Mar 23, 2018

@jungkees Also, how is the implementation capable of synchronously throwing here? The client and its ServiceWorkerContainer may be in another process.

@jungkees

This comment has been minimized.

Copy link
Contributor Author

jungkees commented Mar 26, 2018

@wanderview, thanks for reviewing. Let's discuss in w3c/ServiceWorker#1291.

@jungkees

This comment has been minimized.

Copy link
Contributor Author

jungkees commented Mar 27, 2018

Closing this PR without merging as per the decision made in w3c/ServiceWorker#1291: Client.postMessage to an unloaded client won't throw.

@jungkees jungkees closed this Mar 27, 2018

@jungkees jungkees deleted the jungkees:postmessage-to-unloaded-client branch Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.