Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partial dictionaries #10159

Conversation

Projects
None yet
4 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 23, 2018

Fixes #5714


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Mar 23, 2018

@wpt-pr-bot wpt-pr-bot requested review from ayg, gsnedders, jgraham and tobie Mar 23, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 23, 2018

Build PASSED

Started: 2018-03-28 20:48:23
Finished: 2018-03-28 21:00:54

View more information about this build on:

idlArray.test();
} catch (e) {
return;
}

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Mar 23, 2018

Author Contributor

try/catch code-smell covered by #10162

@lukebjerring lukebjerring force-pushed the lukebjerring:idlharness-partial-dictionary branch from 7b89105 to a33361b Mar 28, 2018

@foolip

foolip approved these changes Mar 28, 2018

Copy link
Contributor

foolip left a comment

Thanks! Added test coverage is great :)

@@ -257,7 +257,8 @@ IdlArray.prototype.internal_add_idls = function(parsed_idls, options)

parsed_idls.forEach(function(parsed_idl)
{
if (parsed_idl.type == "interface" && parsed_idl.partial)
if (parsed_idl.partial
&& ["interface", "dictionary"].find(t => parsed_idl.type == t))

This comment has been minimized.

Copy link
@foolip

foolip Mar 28, 2018

Contributor

Optional simplification: ["interface", "dictionary"].includes(parsed_idl.type) would do the trick here too.

This comment has been minimized.

Copy link
@lukebjerring

lukebjerring Mar 28, 2018

Author Contributor

lol. tried 'contains' and fell back to something I knew. Changed.

@lukebjerring lukebjerring merged commit bc7c640 into web-platform-tests:master Mar 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring deleted the lukebjerring:idlharness-partial-dictionary branch Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.