Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out SVGElement dependency from html.idl #10160

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@annevk
Copy link
Member

annevk commented Mar 23, 2018

Fixes regression caused by #10110.

@annevk annevk requested review from foolip and Hexcles Mar 23, 2018

@wpt-pr-bot wpt-pr-bot requested review from jensl and yuki3 Mar 23, 2018

@Hexcles
Copy link
Member

Hexcles left a comment

LGTM, although I too am not sure what is the best approach here given you said "it seems svg/interfaces.html hasn't really been converted to use mixins thus far and also duplicates some stuff (GlobalEventHandlers)"

@Hexcles

This comment has been minimized.

Copy link
Member

Hexcles commented Mar 23, 2018

BTW I'm also fixing the affected tests from the Chromium side https://crrev.com/c/978508

Both this PR and my CL can fix the current regression independently. And we may also have them both, especially since my CL narrows down the dependencies in a few tests by using add_untested_idls(..., { only: [...] }) so it's good to have anyway.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 23, 2018

Build PASSED

Started: 2018-03-23 17:56:35
Finished: 2018-03-23 18:18:43

View more information about this build on:

@annevk

This comment has been minimized.

Copy link
Member Author

annevk commented Mar 24, 2018

@Hexcles @foolip I'll let you merge this (please use "rebase and merge") if you think this is needed.

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 26, 2018

Since the problem has been fixed I think we should close this and fix https://github.com/w3c/web-platform-tests/blob/master/svg/interfaces.html by creating a new interfaces/svg.idl that matches the current spec. If the current SVG spec's IDL doesn't mix with the current HTML spec's IDL, that's a problem to fix spec-side first.

@lukebjerring, I guess that SVG isn't one of the specs that we have complete IDL to auto-update with?

@foolip foolip closed this Mar 26, 2018

@foolip foolip deleted the annevk/html-idl-quickfix branch Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.