Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test DOM XPath behaviour for root adjacent comments #10168

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@kritisingh1
Copy link
Member

kritisingh1 commented Mar 25, 2018

Reference to one of the tests mentioned in #10072
For now the test fails with the error assert_array_equals: lengths differ, expected 1 got 0 . I think this is somewhat related to the root adjacent thing. @gsnedders could you please look into this and suggest changes? Thanks a lot !

@kritisingh1 kritisingh1 force-pushed the kritisingh1:domxpath branch from ca12cdb to b4cd33a Mar 25, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 25, 2018

Build PASSED

Started: 2018-03-27 17:32:32
Finished: 2018-03-27 17:42:52

View more information about this build on:

<body>
<script>
test(function() {
var result = document.evaluate("comment()", // expression

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 26, 2018

Contributor

Make this //comment().

@@ -0,0 +1,20 @@
<!doctype html>
<title>Root adjacent comment</title>

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 26, 2018

Contributor

Add <!-- foo --> after the doctype before the first element

@kritisingh1

This comment has been minimized.

Copy link
Member Author

kritisingh1 commented Apr 19, 2018

@gsnedders I made the suggested changes quite some time ago. Please review and let me know if any further changes are required. Thanks :)

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Apr 19, 2018

@kritisingh1 See my first comment; comment() needs to be //comment().

@kritisingh1 kritisingh1 force-pushed the kritisingh1:domxpath branch from a457920 to 8177b07 Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.