Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand tests to test in reverse direction #10169

Merged
merged 3 commits into from Mar 28, 2018

Conversation

Projects
None yet
4 participants
@kritisingh1
Copy link
Member

kritisingh1 commented Mar 25, 2018

Reference to issue #2314.
The tests can now test in the opposite direction too as suggested by @Ms2ger .
However, there is a minor fix required regarding the duplicacy of handlers. Please review and suggest any changes required. Thanks :)

@wpt-pr-bot wpt-pr-bot added the html label Mar 25, 2018

@wpt-pr-bot wpt-pr-bot requested review from jdm, jgraham and zqzhang Mar 25, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 25, 2018

Build PASSED

Started: 2018-03-27 18:25:21
Finished: 2018-03-27 18:31:31

View more information about this build on:

@Ms2ger
Copy link
Contributor

Ms2ger left a comment

Now that I look at the test, it might be better to copy the test file and make the changes there; that would prevent any interaction between the tests.

@kritisingh1 kritisingh1 force-pushed the kritisingh1:expand-event-handler branch from 225a1cb to 7a44da7 Mar 26, 2018

@kritisingh1

This comment has been minimized.

Copy link
Member Author

kritisingh1 commented Mar 26, 2018

@Ms2ger I have updated and the tests seem to pass normally. Please have a look. Thanks :)

@Ms2ger
Copy link
Contributor

Ms2ger left a comment

Looks good, but could you also add the part where the attributes are set to null / checked to be null?

@Ms2ger

Ms2ger approved these changes Mar 28, 2018

Copy link
Contributor

Ms2ger left a comment

Thanks!

@Ms2ger Ms2ger merged commit 6fca0b2 into web-platform-tests:master Mar 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.