Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Animations: remove timing objects #10171

Merged
merged 1 commit into from Apr 5, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 25, 2018

The upstream spec has removed the 'timing' objects and replaced them
with updateTiming/getTiming methods on AnimationEffect. It also removed
and renamed a few timing idl interfaces; see the bug for full details.

This CL also refactors the timing input parsing, aiming to make the
public TimingInput API match what the spec requires and not expose
other unnecessary methods.

See w3c/csswg-drafts#2432 for the spec change.

Bug: 823384, 823386
Change-Id: I40c82e46be29c16e2e4b53d69bbadc95c8bff324
Reviewed-on: https://chromium-review.googlesource.com/975923
Reviewed-by: Robert Flack flackr@chromium.org
Reviewed-by: Xida Chen xidachen@chromium.org
Commit-Queue: Stephen McGruer smcgruer@chromium.org
Cr-Commit-Position: refs/heads/master@{#548403}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 25, 2018

Build PASSED

Started: 2018-04-05 13:38:21
Finished: 2018-04-05 13:44:14

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-975923 branch 4 times, most recently from c9dd4eb to 63a6754 Mar 27, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-975923 branch 3 times, most recently from 1c1c545 to 8d34c89 Mar 29, 2018

Web Animations: remove timing objects
The upstream spec has removed the 'timing' objects and replaced them
with updateTiming/getTiming methods on AnimationEffect. It also removed
and renamed a few timing idl interfaces; see the bug for full details.

This CL also refactors the timing input parsing, aiming to make the
public TimingInput API match what the spec requires and not expose
other unnecessary methods.

See w3c/csswg-drafts#2432 for the spec change.

Bug: 823384, 823386
Change-Id: I40c82e46be29c16e2e4b53d69bbadc95c8bff324
Reviewed-on: https://chromium-review.googlesource.com/975923
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548403}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-975923 branch from 8d34c89 to 9ab15c4 Apr 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit f6c1d7b into master Apr 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-975923 branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.