Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service_worker: Add tests for navigation timing #10173

Merged
merged 1 commit into from Mar 27, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 26, 2018

This CL adds some tests for PerformanceNavigationTiming
which are involved with service worker.

  • SW intercepts a navigation
  • SW falls back to network
  • Redirect and SW intercepts a navigation

These tests check workerStart <= fetchStart because starting
a worker should happen before fetching a resource when service
worker is involved.

Bug: 782958
Change-Id: Idd3fa8f76a328e77ee531b81bd91ee3db223f12c
Reviewed-on: https://chromium-review.googlesource.com/979873
Commit-Queue: Kenichi Ishibashi bashi@chromium.org
Reviewed-by: Makoto Shimazu shimazu@chromium.org
Reviewed-by: Matt Falkenhagen falken@chromium.org
Cr-Commit-Position: refs/heads/master@{#545935}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 26, 2018

Build PASSED

Started: 2018-03-27 03:22:13
Finished: 2018-03-27 03:27:47

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-979873 branch 3 times, most recently from f273b9e to d34f4d2 Mar 26, 2018

service_worker: Add tests for navigation timing
This CL adds some tests for PerformanceNavigationTiming
which are involved with service worker.
- SW intercepts a navigation
- SW falls back to network
- Redirect and SW intercepts a navigation

These tests check `workerStart <= fetchStart` because starting
a worker should happen before fetching a resource when service
worker is involved.

Bug: 782958
Change-Id: Idd3fa8f76a328e77ee531b81bd91ee3db223f12c
Reviewed-on: https://chromium-review.googlesource.com/979873
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545935}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-979873 branch from d34f4d2 to a802b10 Mar 27, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9246170 into master Mar 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-979873 branch Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.