Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement snapping for scroll with intended direction and end position. #10181

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 26, 2018

Currently, for scrolls with intended direction and end position, we only
search for snap points that are visible around its end position. However,
we should search for snap points that are visible along the scroll corridor.

This patch implements FindSnapPositionForCorridor and considers
"scroll-snap-top: always" along the search.

Bug: 823998
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I0a73514cc70937db4c88a658ac8f49447e9be5aa

Reviewed-on: https://chromium-review.googlesource.com/972636
WPT-Export-Revision: 2462427bf29cf768decbb10043e6a8a4bf0bd1fa

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 26, 2018

Build PASSED

Started: 2018-03-28 01:59:39
Finished: 2018-03-28 02:04:35

View more information about this build on:

Implement snapping for scroll with intended direction and end position.
Currently, for scrolls with intended direction and end position, we only
search for snap points that are visible around its end position. However,
we should search for snap points that are visible along the scroll corridor.

This patch implements FindSnapPositionForCorridor and considers
"scroll-snap-top: always" along the search.

Bug: 823998
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I0a73514cc70937db4c88a658ac8f49447e9be5aa

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-972636 branch from 885e837 to f9e3995 Mar 28, 2018

@frivoal frivoal added the wg-css label Apr 30, 2018

@chromium-wpt-export-bot

This comment has been minimized.

Copy link
Collaborator Author

chromium-wpt-export-bot commented Oct 4, 2018

Close this PR because the Chromium CL has been abandoned.

@sideshowbarker sideshowbarker deleted the chromium-export-cl-972636 branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.