Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Stub list-valued tests. #10191

Merged
merged 1 commit into from Mar 28, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 27, 2018

Currently we're just adding a TODO when we want to test a list-valued
property. It's probably easier if we stub that test function and then
implement it later.

Bug: 774887
Change-Id: Iab3cea915afbcc8490cacbd45e5632a18e7dece1
Reviewed-on: https://chromium-review.googlesource.com/981956
Reviewed-by: Rune Lillesveen futhark@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#546067}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 27, 2018

Build ERRORED

Started: 2018-03-27 09:23:39
Finished: 2018-03-27 10:17:01

Failing Jobs

  • firefox:nightly

View more information about this build on:

[css-typed-om] Stub list-valued tests.
Currently we're just adding a TODO when we want to test a list-valued
property. It's probably easier if we stub that test function and then
implement it later.

Bug: 774887
Change-Id: Iab3cea915afbcc8490cacbd45e5632a18e7dece1
Reviewed-on: https://chromium-review.googlesource.com/981956
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546067}
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 28, 2018

Looks like Firefox timed out because there were too many affected tests:
https://travis-ci.org/w3c/web-platform-tests/jobs/358793173#L609

That's because css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js was changed.

It looks like the current test isn't printed, so I can't tell how far in the 10 runs we got. This is #7660 and #10028 and I'm going to bypass Travis to merge anyway. (The change passed Chromium's CQ.)

@foolip foolip merged commit 97d4646 into master Mar 28, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@foolip foolip deleted the chromium-export-cl-981956 branch Mar 28, 2018

@darrnshn

This comment has been minimized.

Copy link
Contributor

darrnshn commented Mar 28, 2018

Oops! Should I avoid making such large changes in the future? On a related note, is there something I can do in testsuite.js to prevent it from erroring so much on Firefox..?

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 28, 2018

@darrnshn, no, please keep breaking our upstream infrastructure until we fix it, don't do any extra work for stuff that works fine in Chromium :)

In testsuite.js, if tests fail fast when there API doesn't exist that's quite good enough, and from what I can tell that's the case, I don't see timeouts in Firefox when looking in at a few "random" tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.