Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-land: "Don't adjust the NavigationTimings on redirects" #10193

Merged
merged 1 commit into from Mar 28, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 27, 2018

The reason for revert was the new navigation timing test expectations
(that got commited right before the original change) had a FAIL
expectation for the particular event order that this change was fixing.

Original change's description:

Don't adjust the NavigationTimings on redirects

We adjust the timings in WebDocumentLoaderImpl::UpdateNavigation(),
shouldn't update in each AddRedirect() (which is called in a batch
way after all the redirects are handled in the browser process with PlzNavigate,
adjusting timings there with current timestamp is totally wrong)

R=​ksakamoto,arthursonzogni

Bug: 813889
Change-Id: I3a57d3fdf1833c300feb5ee61737b64cece0946b
Reviewed-on: https://chromium-review.googlesource.com/974673
Reviewed-by: Kunihiko Sakamoto ksakamoto@chromium.org
Commit-Queue: Kinuko Yasuda kinuko@chromium.org
Cr-Commit-Position: refs/heads/master@{#546001}

Bug: 813889
Change-Id: I6f5c0ba1196fa1dd52225036820b29a95569ac21
Reviewed-on: https://chromium-review.googlesource.com/981913
Reviewed-by: Kunihiko Sakamoto ksakamoto@chromium.org
Commit-Queue: Kinuko Yasuda kinuko@chromium.org
Cr-Commit-Position: refs/heads/master@{#546365}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 27, 2018

Build PASSED

Started: 2018-03-28 01:53:18
Finished: 2018-03-28 01:59:35

View more information about this build on:

Re-land: "Don't adjust the NavigationTimings on redirects"
The reason for revert was the new navigation timing test expectations
(that got commited right before the original change) had a FAIL
expectation for the particular event order that this change was fixing.

Original change's description:
> Don't adjust the NavigationTimings on redirects
>
> We adjust the timings in WebDocumentLoaderImpl::UpdateNavigation(),
> shouldn't update in each AddRedirect() (which is called in a batch
> way after all the redirects are handled in the browser process with PlzNavigate,
> adjusting timings there with current timestamp is totally wrong)
>
> R=​ksakamoto,arthursonzogni
>
> Bug: 813889
> Change-Id: I3a57d3fdf1833c300feb5ee61737b64cece0946b
> Reviewed-on: https://chromium-review.googlesource.com/974673
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546001}

Bug: 813889
Change-Id: I6f5c0ba1196fa1dd52225036820b29a95569ac21
Reviewed-on: https://chromium-review.googlesource.com/981913
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546365}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-981913 branch from bf743d2 to 71efe30 Mar 28, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 383fd73 into master Mar 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-981913 branch Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.