Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bfo css backgrounds fix #10195

Closed

Conversation

@faceless2
Copy link
Contributor

faceless2 commented Mar 27, 2018

Tests were referencing the wrong reference test

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 27, 2018

Build PASSED

Started: 2018-04-04 16:37:54
Finished: 2018-04-04 16:39:26

View more information about this build on:

@faceless2

This comment has been minimized.

Copy link
Contributor Author

faceless2 commented Mar 27, 2018

Hello reviewers. This should be a very uncontentious change but I can't seem to get any love from travis. Is it me?

Rune Lillesveen and others added some commits Mar 27, 2018

[css-typed-om] Add support for the column-width property.
Bug: 820299
Change-Id: I9e380416b18f30294fe7cb969a0ce7d0ab1fd7bd
Reviewed-on: https://chromium-review.googlesource.com/977910
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546082}
Merge pull request #10180 from rsolomakhin/method
Replace 'enabledMethods' array with 'method' string.
Port nested sticky tests from reftests to JS tests
Bug: 699244
Change-Id: Ia85a44be9d9f7b0d0db382892520f2755523f514
Reviewed-on: https://chromium-review.googlesource.com/980236
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546172}
Worker: Add tests for import.meta.url on DedicatedWorker
Bug: 680046
Change-Id: Ieb341c5922ad247961ca477893037896dbd88ea6
Reviewed-on: https://chromium-review.googlesource.com/974726
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546254}
[css-typed-om] support r and rx and ry properties
r[1], rx[2], ry[3]
are added to support in whitelist.
and test file are also added.

[1]https://svgwg.org/svg2-draft/geometry.html#R
[2]https://svgwg.org/svg2-draft/geometry.html#RX
[3]https://svgwg.org/svg2-draft/geometry.html#RY

Bug: 820299
Change-Id: I51457648ca07aaf06cf15bd28452d5ad8099d2e3
Reviewed-on: https://chromium-review.googlesource.com/981918
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546302}
[css-typed-om] Support some text-decoration properties.
Adds tests for:
- text-decoration
- text-decoration-line
- text-decoration-skip (not implemented in Blink)
- text-decoration-skip-ink
- text-decoration-width (not implemented in Blink)

text-decoration-line uses a weird internal structure for CSSValues,
so we have to encode/decode to that structure when getting/setting.
Failing tests because for some reason we ignore 'blink' for the
computed value. Blink also doesn't support 'spelling-error' and
'grammar-error' yet.

Bug: 820299
Change-Id: I60e8c3958c9b3a784177c9813a7325aa26e39581
Reviewed-on: https://chromium-review.googlesource.com/981717
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546364}
Re-land: "Don't adjust the NavigationTimings on redirects"
The reason for revert was the new navigation timing test expectations
(that got commited right before the original change) had a FAIL
expectation for the particular event order that this change was fixing.

Original change's description:
> Don't adjust the NavigationTimings on redirects
>
> We adjust the timings in WebDocumentLoaderImpl::UpdateNavigation(),
> shouldn't update in each AddRedirect() (which is called in a batch
> way after all the redirects are handled in the browser process with PlzNavigate,
> adjusting timings there with current timestamp is totally wrong)
>
> R=​ksakamoto,arthursonzogni
>
> Bug: 813889
> Change-Id: I3a57d3fdf1833c300feb5ee61737b64cece0946b
> Reviewed-on: https://chromium-review.googlesource.com/974673
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546001}

Bug: 813889
Change-Id: I6f5c0ba1196fa1dd52225036820b29a95569ac21
Reviewed-on: https://chromium-review.googlesource.com/981913
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546365}
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Apr 4, 2018

@faceless2 it looks like you've accidentally brought in many more commits than you intended, and as a result this PR touches a lot of files, and lots of reviewers have been poked. Can you send a new PR with just your changes and close this PR?

@faceless2

This comment has been minimized.

Copy link
Contributor Author

faceless2 commented Apr 5, 2018

Argh. Sorry. Done.

@faceless2 faceless2 closed this Apr 5, 2018

@faceless2 faceless2 deleted the faceless2:bfo-css-backgrounds-fix branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.