Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-layout-api] Implementation of LayoutConstraints#fixedInlineSize. #10199

Merged
merged 1 commit into from Mar 28, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 27, 2018

This adds the bare bones for the LayoutConstraints object. It just
handles the fixedInlineSize parameter. I expect the information in
this object after the next F2F.

The layout for the test will simply output an autoBlockSize of 100, if
the fixedInlineSize is 100. The tests impose various conditions in
how this can occur, but is certainly not exhaustive.

Change-Id: I6be4a7b77d7b737c778dc2de8b235035b8d3fa22
Bug: 726125
Reviewed-on: https://chromium-review.googlesource.com/981517
Commit-Queue: Ian Kilpatrick ikilpatrick@chromium.org
Reviewed-by: Morten Stenshorne mstensho@chromium.org
Reviewed-by: Emil A Eklund eae@chromium.org
Cr-Commit-Position: refs/heads/master@{#546393}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 27, 2018

Build PASSED

Started: 2018-03-28 20:58:14
Finished: 2018-03-28 21:03:57

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-981517 branch from 3cbc69a to 84a497c Mar 27, 2018

[css-layout-api] Implementation of LayoutConstraints#fixedInlineSize.
This adds the bare bones for the LayoutConstraints object. It just
handles the fixedInlineSize parameter. I expect the information in
this object after the next F2F.

The layout for the test will simply output an autoBlockSize of 100, if
the fixedInlineSize is 100. The tests impose various conditions in
how this can occur, but is certainly not exhaustive.

Change-Id: I6be4a7b77d7b737c778dc2de8b235035b8d3fa22
Bug: 726125
Reviewed-on: https://chromium-review.googlesource.com/981517
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546393}
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 28, 2018

I'm not sure why https://travis-ci.org/w3c/web-platform-tests/jobs/359205244 failed with "EnvironmentError: Servers failed to start: web-platform.test:45196, wss:45196", will try restarting the job.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit c2cd757 into master Mar 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-981517 branch Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.