Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Support animation and transition properties. #10202

Merged
merged 1 commit into from Apr 4, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 28, 2018

This patch supports all the animation/transition properties except
animation-name and transition-property (need spec feedback first).
We also fix the tests so that computed time values use canonical
units as spec'd in [1].

[1] w3c/css-houdini-drafts#725

Bug: 820299
Change-Id: I7c038ce419f8bdb1c789493554776c5e7f9810c7
Reviewed-on: https://chromium-review.googlesource.com/983094
Commit-Queue: Darren Shen shend@chromium.org
Reviewed-by: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/heads/master@{#548017}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 28, 2018

Build ERRORED

Started: 2018-04-04 11:57:56
Finished: 2018-04-04 11:58:58

Failing Jobs

  • firefox:nightly

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-983094 branch from 35b3130 to 68cf549 Apr 4, 2018

[css-typed-om] Support animation and transition properties.
This patch supports all the animation/transition properties except
animation-name and transition-property (need spec feedback first).
We also fix the <time> tests so that computed time values use canonical
units as spec'd in [1].

[1] w3c/css-houdini-drafts#725

Bug: 820299
Change-Id: I7c038ce419f8bdb1c789493554776c5e7f9810c7
Reviewed-on: https://chromium-review.googlesource.com/983094
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548017}
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Apr 4, 2018

Timeout of Firefox job looks like it's because of #7660.

@foolip foolip merged commit e502344 into master Apr 4, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@foolip foolip deleted the chromium-export-cl-983094 branch Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.