Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] Add support for marker properties. #10205

Merged
merged 1 commit into from Mar 29, 2018

Conversation

Projects
None yet
5 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 28, 2018

This patch adds support for marker, marker-start, marker-end, marker-mid
We also had to add a new CSS data type , but because it's not
spec'd yet, we can't really test it.

Bug: 820299
Change-Id: Ie3f851be3d65396705594d99582ac3e87e3fc57d
Reviewed-on: https://chromium-review.googlesource.com/983192
Reviewed-by: Rune Lillesveen futhark@chromium.org
Commit-Queue: Darren Shen shend@chromium.org
Cr-Commit-Position: refs/heads/master@{#546645}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 28, 2018

Build ERRORED

Started: 2018-03-28 23:15:46
Finished: 2018-03-29 00:06:45

Failing Jobs

  • firefox:nightly

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-983192 branch from 11bd20e to 2077fed Mar 28, 2018

[css-typed-om] Add support for marker properties.
This patch adds support for marker, marker-start, marker-end, marker-mid
We also had to add a new CSS data type <url>, but because it's not
spec'd yet, we can't really test it.

Bug: 820299
Change-Id: Ie3f851be3d65396705594d99582ac3e87e3fc57d
Reviewed-on: https://chromium-review.googlesource.com/983192
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546645}
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 29, 2018

Like #10191, this touches a shared testsuite.js and I believe the Firefox failure is due to #7660. Will merge manually.

@foolip foolip merged commit 604d17e into master Mar 29, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@foolip foolip deleted the chromium-export-cl-983192 branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.