Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: FakeBluetoothChooser impl. #10224

Merged
merged 1 commit into from Mar 29, 2018

Conversation

Projects
None yet
6 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 28, 2018

Implements the interfaces that FakeBluetoothChooser overrides. The
mojom::FakeBluetoothChooser overrides are implemented by running
|event_handler_| with the appropriate arguments. The BluetoothChooser
overrides do nothing at the moment, since the base class is only meant
to update the chooser user interface.

This change also begins to partially convert a Bluetooth chooser test to test
the interface and deletes the temporary tests that were created to test this
API.

This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
reverted the original change. The original change caused the
new-scan-device-added.html test to fail because of a Mojo validation error
resulting from not updating the
third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
file needed by the test.

Bug: 719827, 719826, 824704, 826787
Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
Reviewed-on: https://chromium-review.googlesource.com/985195
Commit-Queue: Ovidio Henriquez odejesush@chromium.org
Reviewed-by: Giovanni Ortuño Urquidi ortuno@chromium.org
Reviewed-by: Daniel Cheng dcheng@chromium.org
Cr-Commit-Position: refs/heads/master@{#546729}


This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Revert "Revert "bluetooth: FakeBluetoothChooser impl."" bluetooth: FakeBluetoothChooser impl. Mar 28, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-985195 branch from 24e828e to fff0e5a Mar 28, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 28, 2018

Build ERRORED

Started: 2018-03-29 07:51:25
Finished: 2018-03-29 08:40:52

Failing Jobs

  • firefox:nightly

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-985195 branch from fff0e5a to 6d12e01 Mar 29, 2018

bluetooth: FakeBluetoothChooser impl.
Implements the interfaces that FakeBluetoothChooser overrides. The
mojom::FakeBluetoothChooser overrides are implemented by running
|event_handler_| with the appropriate arguments. The BluetoothChooser
overrides do nothing at the moment, since the base class is only meant
to update the chooser user interface.

This change also begins to partially convert a Bluetooth chooser test to test
the interface and deletes the temporary tests that were created to test this
API.

This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
reverted the original change. The original change caused the
new-scan-device-added.html test to fail because of a Mojo validation error
resulting from not updating the
third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
file needed by the test.

Bug: 719827, 719826, 824704, 826787
Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
Reviewed-on: https://chromium-review.googlesource.com/985195
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546729}
@rakuco

This comment has been minimized.

Copy link
Contributor

rakuco commented Mar 29, 2018

@foolip is this another instance of the "too many affected tests breaks Firefox" bug?

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 29, 2018

@rakuco yes, it certainly looks like it, the list of affected tests is quite long and the job timed out. Blaming #7660.

@foolip foolip merged commit 9c86b93 into master Mar 29, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@foolip foolip deleted the chromium-export-cl-985195 branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.