Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebDriver: add more WebKit workarounds to detect whether a window is fullscreen #10226

Conversation

Projects
None yet
4 participants
@burg
Copy link
Contributor

burg commented Mar 28, 2018

WebKit doesn't conform to the Fullscreen API yet, so we need to use
the vendor prefixed property to check whether the window is fullscreen.

This workaround was previously applied to fullscreen_window.py, but it
needs to happen in other places as well.

Brian Burg
WebDriver: add more WebKit workarounds to detect whether a window is …
…fullscreen

WebKit doesn't implement the Fullscreen API yet, so we need to use
the vendor prefixed property to check whether the window is fullscreen.

This workaround was previously applied to fullscreen_window.py, but it
needs to happen in other places as wel.
@burg

This comment has been minimized.

Copy link
Contributor Author

burg commented Mar 28, 2018

Please advise if there is a better way to reuse the is_fullscreen helper method.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 29, 2018

Build PASSED

Started: 2018-03-28 23:50:05
Finished: 2018-03-29 00:01:03

View more information about this build on:

@andreastt andreastt merged commit 592e2ed into web-platform-tests:master Mar 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.