Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Add WPT tests for basic ::part() functionality. #10228

Merged
merged 1 commit into from Apr 5, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 29, 2018

https://drafts.csswg.org/css-shadow-parts/

Tests cover the following:

  • Simple - Part in selected host is styled
  • Host Stylesheet - Part in selected host is not styled by ::part in a stylesheet inside the host
  • Different Host - Part is not styled when host is not selected
  • Inner Host
  • Part in outer host is styled by document style sheet
  • Part in inner host is not styled by document style sheet
  • Compound Positive - Compound selector for host works
  • Compound Negative - Non-matching compound selector for host does not style
  • All Hosts
  • ::part with host selector styles in first host
  • ::part with host selector styles in second host
  • Chaining Negative - ::part cannot be chained to reach elements in the inner host

Bug: 805271
Change-Id: I8c16ae09547bd833dbcc1eb0afb8be91a40c0a8e
Reviewed-on: https://chromium-review.googlesource.com/983833
Commit-Queue: Fergal Daly fergal@chromium.org
Reviewed-by: Rune Lillesveen futhark@chromium.org
Reviewed-by: Takayoshi Kochi kochi@chromium.org
Cr-Commit-Position: refs/heads/master@{#548349}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 29, 2018

Build PASSED

Started: 2018-04-05 06:34:25
Finished: 2018-04-05 06:41:31

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-983833 branch 9 times, most recently from 4f32868 to 199c555 Mar 29, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-983833 branch from 199c555 to 3f33311 Apr 5, 2018

CSS: Add WPT tests for basic ::part() functionality.
https://drafts.csswg.org/css-shadow-parts/

Tests cover the following:
- Simple - Part in selected host is styled
- Host Stylesheet - Part in selected host is not styled by ::part in a stylesheet inside the host
- Different Host - Part is not styled when host is not selected
- Inner Host
 - Part in outer host is styled by document style sheet
 - Part in inner host is not styled by document style sheet
- Compound Positive - Compound selector for host works
- Compound Negative - Non-matching compound selector for host does not style
- All Hosts
 - ::part with host selector styles in first host
 - ::part with host selector styles in second host
- Chaining Negative - ::part cannot be chained to reach elements in the inner host

Bug: 805271
Change-Id: I8c16ae09547bd833dbcc1eb0afb8be91a40c0a8e
Reviewed-on: https://chromium-review.googlesource.com/983833
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548349}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-983833 branch from 3f33311 to f1a4e49 Apr 5, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 54f844c into master Apr 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-983833 branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.