Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-align] tests for row-gap / column-gap normal #10232

Merged
merged 2 commits into from Mar 30, 2018

Conversation

Projects
None yet
4 participants
@frivoal
Copy link
Contributor

frivoal commented Mar 29, 2018

Matching the w3c/csswg-drafts#2294 spec change

Not including tests for used value in multicol, because (so far) it is
UA defined.

[css-aling] tests for row-gap / column-gap normal
Matching the w3c/csswg-drafts#2294 spec change

Not including tests for used value in multicol, because (so far) it is
UA defined.

@wpt-pr-bot wpt-pr-bot requested review from dholbert and emilio Mar 29, 2018

@frivoal frivoal requested a review from mrego Mar 29, 2018

@frivoal frivoal self-assigned this Mar 29, 2018

@frivoal frivoal added the wg-css label Mar 29, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 29, 2018

Build PASSED

Started: 2018-03-30 04:21:22
Finished: 2018-03-30 04:26:04

View more information about this build on:

@emilio emilio changed the title [css-aling] tests for row-gap / column-gap normal [css-align] tests for row-gap / column-gap normal Mar 29, 2018

@emilio

emilio approved these changes Mar 29, 2018

Copy link
Contributor

emilio left a comment

Looks good to me, it'd be nice to add references that instead of a green square just use column-gap: 0 and row-gap: 0?

Not a big deal I guess, the tests are clear anyway.

<meta charset="utf-8">
<title>CSS Box Alignment Test: computed value of normal on *-gap properties</title>
<link rel="author" title="Florian Rivoal" href="https://florian.rivoal.net">
<link rel="help" href="https://www.w3.org/TR/css-align-3/#column-row-gap">

This comment has been minimized.

Copy link
@emilio

emilio Mar 29, 2018

Contributor

nit: Maybe link to the draft instead? Not sure what the policy is.

This comment has been minimized.

Copy link
@frivoal

frivoal Mar 30, 2018

Author Contributor

I believe the policy is somewhat fuzzy, but that linking to TR when the text we want is on TR is preferred, and that linking to the ED otherwise is OK. I wouldn't lose sleep over it :)

and there are implementations that support column-gap without supporting the shorthand */
colum-gap: normal;
row-gap: normal;
float: right; /* for shrinwrap*/

This comment has been minimized.

Copy link
@emilio

emilio Mar 29, 2018

Contributor

typo: Shrinkwrap.

This comment has been minimized.

Copy link
@frivoal

frivoal Mar 30, 2018

Author Contributor

thanks

background: red;
}
</style>
<body>

This comment has been minimized.

Copy link
@emilio

emilio Mar 29, 2018

Contributor

nit: This <body> is unclosed, but I'd just remove it here and everywhere else... Your call.

This comment has been minimized.

Copy link
@frivoal

frivoal Mar 30, 2018

Author Contributor

removing it altogether

@frivoal frivoal merged commit d01ce10 into web-platform-tests:master Mar 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.