Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document useful arguments for `wpt run chrome` #10238

Merged
merged 6 commits into from Apr 4, 2018

Conversation

Projects
None yet
5 participants
@foolip
Copy link
Contributor

foolip commented Mar 29, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot added the docs label Mar 29, 2018

@foolip foolip requested review from kereliuk and removed request for gsnedders, sideshowbarker and dontcallmedom Mar 29, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 29, 2018

Build PASSED

Started: 2018-04-03 21:49:52
Finished: 2018-04-03 21:56:19

View more information about this build on:

@kereliuk
Copy link
Contributor

kereliuk left a comment

LGTM, thanks for adding these!

To enable experimental web platform features:

```
./wpt run --binary-arg=--enable-experimental-web-platform-features chrome fullscreen/

This comment has been minimized.

Copy link
@kereliuk

kereliuk Apr 3, 2018

Contributor

nit: can you add a link that gives more explanation of what this flag does?

This comment has been minimized.

Copy link
@foolip

foolip Apr 3, 2018

Author Contributor

Will link to https://www.chromium.org/blink/runtime-enabled-features and chrome://flags/#enable-experimental-web-platform-features

This comment has been minimized.

Copy link
@foolip

foolip Apr 3, 2018

Author Contributor

Well, that was harder than I thought, but PTAL.

foolip added some commits Apr 3, 2018

@@ -13,8 +13,7 @@ run Chrome Dev on Linux:

Extra arguments to Chrome can be passed with `--binary-args`.

To enable all [experimental web platform features](https://www.chromium.org/blink/runtime-enabled-features)
[Experimental Web Platform features](chrome://flags/#enable-experimental-web-platform-features):
To enable all [experimental web platform features](https://www.chromium.org/blink/runtime-enabled-features) (chrome://flags/#enable-experimental-web-platform-features):

This comment has been minimized.

Copy link
@gsnedders

gsnedders Apr 3, 2018

Contributor

This seems wrong per the commit message; I presume you meant to keep the https link here.

This comment has been minimized.

Copy link
@foolip

foolip Apr 4, 2018

Author Contributor

I did keep one https link, it's just chrome:// which seems impossible to make a link from.

@foolip foolip merged commit 162e9dd into master Apr 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@foolip foolip deleted the document-chrome-args branch Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.