Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCPeerConnection.getStats(MediaStreamTrack? selector = null) added. #10247

Merged
merged 1 commit into from Apr 4, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 29, 2018

Implements the RTCPeerConnection.getStats(MediaStreamTrack) version[1]
of the stats selection algorithm behind flag. This is the equivalent of
doing RTCRtpSender.getStats() or RTCRtpReceiver.getStats() for the
track's sender or receiver. This is tested in external/wpt/.

Due to limitations of the generated V8 bindings it is not possible to
express all versions of RTCPeerConnection.getStats() at the same time
in IDL. Thus this CL introduces a version of getStats() taking
"optional any callbacksOrSelector" as argument, with custom binding
logic performed in RTCPeerConnection.cpp. A fast/peerconnection/
LayoutTest is added to test all combinations.

[1] https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-getstats

Bug: 680172
Change-Id: I8c64fc64c708d266c926dfa3eb3587c4cbb31210
Reviewed-on: https://chromium-review.googlesource.com/978128
Commit-Queue: Henrik Boström hbos@chromium.org
Reviewed-by: Philip Jägenstedt foolip@chromium.org
Reviewed-by: Harald Alvestrand hta@chromium.org
Cr-Commit-Position: refs/heads/master@{#548149}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 29, 2018

Build PASSED

Started: 2018-04-04 22:43:46
Finished: 2018-04-04 22:51:01

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-978128 branch 4 times, most recently from 30912f7 to 36693c7 Mar 31, 2018

RTCPeerConnection.getStats(MediaStreamTrack? selector = null) added.
Implements the RTCPeerConnection.getStats(MediaStreamTrack) version[1]
of the stats selection algorithm behind flag. This is the equivalent of
doing RTCRtpSender.getStats() or RTCRtpReceiver.getStats() for the
track's sender or receiver. This is tested in external/wpt/.

Due to limitations of the generated V8 bindings it is not possible to
express all versions of RTCPeerConnection.getStats() at the same time
in IDL. Thus this CL introduces a version of getStats() taking
"optional any callbacksOrSelector" as argument, with custom binding
logic performed in RTCPeerConnection.cpp. A fast/peerconnection/
LayoutTest is added to test all combinations.

[1] https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-getstats

Bug: 680172
Change-Id: I8c64fc64c708d266c926dfa3eb3587c4cbb31210
Reviewed-on: https://chromium-review.googlesource.com/978128
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548149}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-978128 branch from 36693c7 to c1df8c2 Apr 4, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 7ba8056 into master Apr 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-978128 branch Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.