Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for DocumentAndElementEventHandlers in SVG #10249

Merged

Conversation

Projects
None yet
6 participants
@dstorey
Copy link
Contributor

dstorey commented Mar 29, 2018

Based on html/webappapis/scripting/events/event-handler-all-document-element-events.html but for cut/copy/paste and only testing SVGElement, and using SVG template

This is part of ACTION-3867

Add test for DocumentAndElementEventHandlers in SVG
Based on html/webappapis/scripting/events/event-handler-all-document-element-events.html but for cut/copy/paste and only testing SVGElement, and using SVG template
@dstorey

This comment has been minimized.

Copy link
Contributor Author

dstorey commented Mar 29, 2018

This is not in the spec yet. This adds tests before we commit the change to allow DocumentAndElementEventHandlers on SVGElement. This mixes in oncopy/cut/paste.

Firefox currently allows them on SVGElement (but fails tests). Chrome and Safari implement them on Element (which fails for HTML where they suppose to be on HTMLElement). Edge doesn't currently support them on SVGElement, but I have a PR close to sign off to add them.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 29, 2018

Build PASSED

Started: 2018-03-29 23:41:28
Finished: 2018-03-29 23:51:48

View more information about this build on:

@dstorey

This comment has been minimized.

Copy link
Contributor Author

dstorey commented Apr 2, 2018

These now pass in Edge :)

dstorey added a commit to dstorey/svgwg that referenced this pull request Apr 12, 2018

Add DocumentAndElementEventHandlers
Supported by Firefox and Edge (upcoming version) as specified. Supported by Chrome and Safari on Element (HTML defines them on HTMLElement)

Tests: web-platform-tests/wpt#10249
@Ms2ger

This comment has been minimized.

Copy link
Contributor

Ms2ger commented Jun 1, 2018

@smaug---- I think this exposes a bug in IsEventAttributeNameInternal for SVG; Gecko is not compiling the content attributes.

@Ms2ger

Ms2ger approved these changes Jun 1, 2018

<h:script src="/resources/testharnessreport.js"/>
<script><![CDATA[
"use strict";
setup({ explicit_done: true });

This comment has been minimized.

Copy link
@Ms2ger

Ms2ger Jun 1, 2018

Contributor

There does not seem to be a need for this. Please remove it (and the done() call). I'd be happy to get the PR merged some time next week if you don't have time, though.

@smaug----

This comment has been minimized.

Copy link
Contributor

smaug---- commented Jun 1, 2018

@svgeesus svgeesus merged commit 1529e32 into web-platform-tests:master Aug 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.