Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for used column-count when column-count/width are not auto #10250

Merged
merged 3 commits into from Jun 5, 2018

Conversation

Projects
None yet
5 participants
@gsnedders
Copy link
Contributor

gsnedders commented Mar 30, 2018

Inspired by a bug in Prince (which I think is just what's reported at https://www.princexml.com/forum/topic/3804/column-count-anomalies-any-ideas).

@gsnedders gsnedders requested review from frivoal and rachelandrew Mar 30, 2018

@wpt-pr-bot wpt-pr-bot requested a review from mstensho Mar 30, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 30, 2018

Build PASSED

Started: 2018-03-30 03:11:27
Finished: 2018-03-30 03:21:25

View more information about this build on:

<title>column-count used value test ref</title>
<style>
ul {
font: 20px/1 Ahem;

This comment has been minimized.

Copy link
@mstensho

mstensho Mar 30, 2018

Contributor

To simplify the test, we could just use DIVs with a blank line created by BR elements. We don't need Ahem, and also not UL or LI. If you set orphans and widows to 1, the contents of the multicol container could simply be

<br><br><br><br>

(i.e. no need for any LI/DIV wrapper for each line)

It would be even better with a test that would just match one of the refs in ../reference/ , of course ("green square" something).

This comment has been minimized.

Copy link
@gsnedders

gsnedders Jun 5, 2018

Author Contributor

@mstensho does this look better? oddly, it fails in Safari, as the green box is 108px high, and I don't know if I'm missing something as to why.

@frivoal frivoal added the wg-css label Apr 30, 2018

@gsnedders gsnedders force-pushed the gsnedders:column-count-used branch from 7cf8b31 to 8ec6cc0 Jun 5, 2018

height: 100px;
}
.test {
font: 50px/1 sans-serif;

This comment has been minimized.

Copy link
@mstensho

mstensho Jun 5, 2018

Contributor

Use line-height:50px instead of specifying font, and there should be less trouble.

font: 50px/1 sans-serif;
width: 100px;
background: green;
columns: 2 20px;

This comment has been minimized.

Copy link
@mstensho

mstensho Jun 5, 2018

Contributor

This is pretty over-constrained, since the available width is already specified. I suggest "columns:2".

This comment has been minimized.

Copy link
@gsnedders

gsnedders Jun 5, 2018

Author Contributor

This is specifically testing the case where column-width is not auto, because that's the case where Prince gets it wrong.

This comment has been minimized.

Copy link
@mstensho

mstensho Jun 5, 2018

Contributor

Doh, right. I forgot what this was about.

@gsnedders gsnedders merged commit 8b089cb into web-platform-tests:master Jun 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the gsnedders:column-count-used branch Jun 5, 2018

@gsnedders gsnedders restored the gsnedders:column-count-used branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.