New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "bluetooth: FakeBluetoothChooser impl." #10260

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Collaborator

chromium-wpt-export-bot commented Mar 30, 2018

This is a reland of 6a337f19713e049cd42969b0c909c59aff4146cd

This previous change caused tests to fail because of a Mojo validation
error, which is now taken care of by setting the scramble_message_ids flag in
the BUILD.gn file to false.

Original change's description:

bluetooth: FakeBluetoothChooser impl.

Implements the interfaces that FakeBluetoothChooser overrides. The
mojom::FakeBluetoothChooser overrides are implemented by running
|event_handler_| with the appropriate arguments. The BluetoothChooser
overrides do nothing at the moment, since the base class is only meant
to update the chooser user interface.

This change also begins to partially convert a Bluetooth chooser test to test
the interface and deletes the temporary tests that were created to test this
API.

This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
reverted the original change. The original change caused the
new-scan-device-added.html test to fail because of a Mojo validation error
resulting from not updating the
third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
file needed by the test.

Bug: 719827, 719826, 824704, 826787
Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
Reviewed-on: https://chromium-review.googlesource.com/985195
Commit-Queue: Ovidio Henriquez odejesush@chromium.org
Reviewed-by: Giovanni Ortuño Urquidi ortuno@chromium.org
Reviewed-by: Daniel Cheng dcheng@chromium.org
Cr-Commit-Position: refs/heads/master@{#546729}

Bug: 719827, 719826, 824704, 826787
Change-Id: If63a681becbb2ac0f646a11ea20b1db18d42395d
Reviewed-on: https://chromium-review.googlesource.com/986593
WPT-Export-Revision: 49ce2732934ce26f351251d0084c1ed3abd1d657


This change is Reviewable

Reland "bluetooth: FakeBluetoothChooser impl."
This is a reland of 6a337f19713e049cd42969b0c909c59aff4146cd

This previous change caused tests to fail because of a Mojo validation
error, which is now taken care of by setting the scramble_message_ids flag in
the BUILD.gn file to false.

Original change's description:
> bluetooth: FakeBluetoothChooser impl.
>
> Implements the interfaces that FakeBluetoothChooser overrides. The
> mojom::FakeBluetoothChooser overrides are implemented by running
> |event_handler_| with the appropriate arguments. The BluetoothChooser
> overrides do nothing at the moment, since the base class is only meant
> to update the chooser user interface.
>
> This change also begins to partially convert a Bluetooth chooser test to test
> the interface and deletes the temporary tests that were created to test this
> API.
>
> This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
> reverted the original change. The original change caused the
> new-scan-device-added.html test to fail because of a Mojo validation error
> resulting from not updating the
> third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
> file needed by the test.
>
> Bug: 719827, 719826, 824704, 826787
> Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
> Reviewed-on: https://chromium-review.googlesource.com/985195
> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546729}

Bug: 719827, 719826, 824704, 826787
Change-Id: If63a681becbb2ac0f646a11ea20b1db18d42395d
@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Mar 30, 2018

Build ERRORED

Started: 2018-03-30 22:27:03
Finished: 2018-03-30 23:17:32

Failing Jobs

  • firefox:nightly

View more information about this build on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment