Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Pointer Lock IDL tests #10261

Merged
merged 2 commits into from May 28, 2018

Conversation

Projects
None yet
4 participants
@foolip
Copy link
Contributor

foolip commented Mar 30, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from scheib and siusin Mar 30, 2018

@foolip foolip requested a review from lukebjerring Mar 30, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 30, 2018

Build PASSED

Started: 2018-03-30 22:44:59
Finished: 2018-03-30 22:55:30

View more information about this build on:

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Mar 31, 2018

@rakuco rakuco requested a review from NavidZ Apr 5, 2018

@lukebjerring
Copy link
Contributor

lukebjerring left a comment

Sorry, this slipped under the radar months ago.

I think we'd be better off using the new {only: 'EventInit'...} or wait for #10381

@lukebjerring
Copy link
Contributor

lukebjerring left a comment

@foolip - I took the liberty of updating your PR.. and approve my own work.

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented May 23, 2018

I checked the new diff and emphatically approve :)

@lukebjerring lukebjerring merged commit c54825a into master May 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring deleted the fix-pointerlock-idlharness branch May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.