New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serialization of timing functions #10263

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
None yet
4 participants
@csnardi
Member

csnardi commented Apr 1, 2018

According to https://drafts.csswg.org/css-timing/#serializing-a-timing-function:

The keyword values ease, linear, ease-in, ease-out, and ease-in-out are serialized as-is, that-is, they are not converted to the equivalent cubic-bezier() function.

Update two tests to match this behavior.

@wpt-pr-bot wpt-pr-bot requested a review from dbaron Apr 1, 2018

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 1, 2018

Build PASSED

Started: 2018-04-01 02:12:18
Finished: 2018-04-01 02:19:10

View more information about this build on:

@csnardi

This comment has been minimized.

Member

csnardi commented Apr 7, 2018

@ewilligers Can you review this?

Update serialization of timing functions
According to https://drafts.csswg.org/css-timing/#serializing-a-timing-function, "The keyword values ease, linear, ease-in, ease-out, and ease-in-out are serialized as-is, that-is, they are not converted to the equivalent cubic-bezier() function". Update two tests to match this behavior.
@csnardi

This comment has been minimized.

Member

csnardi commented Apr 13, 2018

@ewilligers Could you also merge (or should I bug someone for permissions to do that)?

@ewilligers ewilligers merged commit 7b20d12 into web-platform-tests:master Apr 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@csnardi csnardi deleted the csnardi:patch-10 branch Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment