New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test that CSSStyleSheet.media is read-only #10264

Merged
merged 1 commit into from Apr 2, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Collaborator

chromium-wpt-export-bot commented Apr 1, 2018

style-sheet-interfaces-001.html tested that styleSheet.media was
read-only, but the spec changed to add a [PutForwards] attribute to
|media|, meanining that the attribute is no longer truly read-only.
assert_readonly can have side-effects if the property has a
[PutForwards] attribute, so remove this check, as it was causing the
next test to fail.

Bug: 821780
Change-Id: I77bee2f11484f6e679e4aee6b0641179c686d1d3
Reviewed-on: https://chromium-review.googlesource.com/989407
Reviewed-by: Emil A Eklund eae@chromium.org
Commit-Queue: Chris Nardi cnardi@chromium.org
Cr-Commit-Position: refs/heads/master@{#547451}

@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 2, 2018

Build PASSED

Started: 2018-04-02 17:05:08
Finished: 2018-04-02 17:11:37

View more information about this build on:

Remove test that CSSStyleSheet.media is read-only
style-sheet-interfaces-001.html tested that styleSheet.media was
read-only, but the spec changed to add a [PutForwards] attribute to
|media|, meanining that the attribute is no longer truly read-only.
assert_readonly can have side-effects if the property has a
[PutForwards] attribute, so remove this check, as it was causing the
next test to fail.

Bug: 821780
Change-Id: I77bee2f11484f6e679e4aee6b0641179c686d1d3
Reviewed-on: https://chromium-review.googlesource.com/989407
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547451}

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit af485dc into master Apr 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-989407 branch Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment