New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix customElements.upgrade() tests for <template> #10272

Merged
merged 2 commits into from Apr 3, 2018

Conversation

@domenic
Member

domenic commented Apr 2, 2018

See #9869 (comment). @bicknellr please take a look! Thank you for finding this.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 2, 2018

Build PASSED

Started: 2018-04-02 19:30:49
Finished: 2018-04-02 19:39:56

View more information about this build on:

assert_true(el2 instanceof Element2, "element 2 must still not be upgraded after upgrading the template contents");
assert_true(el3 instanceof Element3, "element 3 must still not be upgraded after upgrading the template contents");
assert_true(el4 instanceof Element4, "element 4 must still not be upgraded after upgrading the template contents");
assert_true(el5 instanceof Element5, "element 5 must still not be upgraded after upgrading the template contents");

This comment has been minimized.

@bicknellr

bicknellr Apr 2, 2018

assert_true -> assert_false for these lines

This comment has been minimized.

@domenic

domenic Apr 2, 2018

Member

goodness -_-

@bicknellr

This comment has been minimized.

bicknellr commented Apr 2, 2018

👍

@tkent-google tkent-google merged commit 5b68d21 into master Apr 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tkent-google tkent-google deleted the ce-upgrade-fix branch Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment