New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gradient color-stops parsing test #10274

Merged
merged 1 commit into from May 26, 2018

Conversation

Projects
None yet
7 participants
@fmalita
Contributor

fmalita commented Apr 2, 2018

This also adds some coverage for parsing CSS Image Values and Replaced
Content Module Level 4 conic-gradient [1] and dual-positioned stops [2].

[1] https://www.w3.org/TR/css-images-4/#conic-gradients
[2] https://www.w3.org/TR/css-images-4/#typedef-color-stop-length

Add a gradient color-stops parsing test
This also adds some coverage for parsing CSS Image Values and Replaced
Content Module Level 4 conic-gradient() and dual-positioned stops.

@wpt-pr-bot wpt-pr-bot requested review from fantasai, plinss and tabatkins Apr 2, 2018

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 2, 2018

Build PASSED

Started: 2018-04-02 19:23:42
Finished: 2018-04-02 19:34:41

View more information about this build on:

@frivoal frivoal added the wg-css label Apr 30, 2018

@svgeesus svgeesus requested a review from LeaVerou May 1, 2018

@svgeesus

This comment has been minimized.

Contributor

svgeesus commented May 1, 2018

@LeaVerou this could use a review from you, I think.

@LeaVerou

Looks good to me 👍

@fmalita

This comment has been minimized.

Contributor

fmalita commented May 3, 2018

Thanks Lea!

I think I also need approval from @tabatkins / @fantasai / @plinss to merge?

@fmalita

This comment has been minimized.

Contributor

fmalita commented May 22, 2018

@tabatkins @fantasai @plinss could you take a look at this? Thanks!

@emilio

emilio approved these changes May 26, 2018

@emilio emilio merged commit 7b40de7 into web-platform-tests:master May 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment