New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadableStream to latest standard version #10277

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Collaborator

chromium-wpt-export-bot commented Apr 3, 2018

Update Blink's implementation of ReadableStream to
https://streams.spec.whatwg.org/commit-snapshots/37ace3d5f16cbea7aec4a0c80532c95059994d51/

This also updates TransformStream to use CreateReadableStream() instead
of calling the ReadableStream constructor.

Several common operations have become unused and have been removed.

The EXTERNALLY_CONTROLLED flag has been renamed to the slightly more
specific name "BLINK_LOCK_NOTIFICATIONS".

All external/wpt/streams/readable-streams tests now pass, and failing
expectations have been removed.

Most changes were already covered by the web-platform-tests. A new
readable-streams/patched-global.js test verifies that
ReadableStreamTee() does not use the global ReadableStream constructor
or otherwise touch the global object.

BUG=710728

Change-Id: I2b799045f47376adef305f5f88ad106161425b46
Reviewed-on: https://chromium-review.googlesource.com/992077
Commit-Queue: Adam Rice ricea@chromium.org
Reviewed-by: Yutaka Hirano yhirano@chromium.org
Cr-Commit-Position: refs/heads/master@{#548784}

@wpt-pr-bot

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

w3c-bots commented Apr 3, 2018

Build ERRORED

Started: 2018-04-03 10:10:18
Finished: 2018-04-03 10:24:27

Failing Jobs

  • firefox:nightly

Unstable Results

Browser: "Firefox Nightly"

View in: WPT PR Status | TravisCI

Test Subtest Results Messages
/streams/readable-streams/patched-global.dedicatedworker.html   OK: 1
  Untitled FAIL: 1
ReferenceError: ReadableStream is not defined
Update ReadableStream to latest standard version
Update Blink's implementation of ReadableStream to
https://streams.spec.whatwg.org/commit-snapshots/37ace3d5f16cbea7aec4a0c80532c95059994d51/

This also updates TransformStream to use CreateReadableStream() instead
of calling the ReadableStream constructor.

Several common operations have become unused and have been removed.

The EXTERNALLY_CONTROLLED flag has been renamed to the slightly more
specific name "BLINK_LOCK_NOTIFICATIONS".

All external/wpt/streams/readable-streams tests now pass, and failing
expectations have been removed.

Most changes were already covered by the web-platform-tests. A new
readable-streams/patched-global.js test verifies that
ReadableStreamTee() does not use the global ReadableStream constructor
or otherwise touch the global object.

BUG=710728

Change-Id: I2b799045f47376adef305f5f88ad106161425b46
Reviewed-on: https://chromium-review.googlesource.com/992077
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548784}

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 8314b7b into master Apr 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-992077 branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment