Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebNFC: Use [SecureContext] instead of manual check #10284

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Apr 3, 2018

Until now, we had to use IsSecureContext() to check whether an execution
context is a secure context manually. But we can use [SecureContext]
instead of the manual check now.

Related spec change:
w3c/web-nfc#143
w3c/web-nfc#144

Bug: none
Change-Id: I1396470cc57aeba137ddba65d1f29eb58cf9cf9b
Reviewed-on: https://chromium-review.googlesource.com/989537
Reviewed-by: Alexander Shalamov alexander.shalamov@intel.com
Commit-Queue: Jinho Bang jinho.bang@samsung.com
Cr-Commit-Position: refs/heads/master@{#548744}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Apr 3, 2018

Build PASSED

Started: 2018-04-03 16:31:44
Finished: 2018-04-03 16:39:25

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-989537 branch 2 times, most recently from 7c819d0 to 51f85da Apr 5, 2018

WebNFC: Use [SecureContext] instead of manual check
Until now, we had to use IsSecureContext() to check whether an execution
context is a secure context manually. But we can use [SecureContext]
instead of the manual check now.

Related spec change:
  w3c/web-nfc#143
  w3c/web-nfc#144

Bug: none
Change-Id: I1396470cc57aeba137ddba65d1f29eb58cf9cf9b
Reviewed-on: https://chromium-review.googlesource.com/989537
Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#548744}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-989537 branch from 51f85da to ab86a31 Apr 6, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 11740d8 into master Apr 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-989537 branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.