Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for // META: spec=url to satisfy MISSING-LINK #10289

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Apr 3, 2018

Fixes #5770.

  • Whitelists // META: spec=url as a valid META tag (stops UNKNOWN-METADATA)
  • Surfaces url from the above expression in the set of SourceFile.spec_links

Note that this does not affect what is considered a valid link; opened #10288 to cover that.


This change is Reviewable

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Apr 3, 2018

Build BROKEN

Started: 2018-04-03 20:23:23
Finished: 2018-04-03 20:44:47

Failing Jobs

  • tools_unittest in py36

View more information about this build on:

lukebjerring added some commits Apr 3, 2018

@foolip

foolip approved these changes Apr 3, 2018

Copy link
Contributor

foolip left a comment

@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Apr 3, 2018

And, uh, not quite sure what to make of this Travis failure: https://travis-ci.org/w3c/web-platform-tests/jobs/361820644

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Apr 3, 2018

The point of this lint it to ensure that the CSS build system can find the tests; as such, for this to make sense, the CSS build system also needs to be updated to support it. Note that the biggest use of the CSS build system is on test.csswg.org/, and that doesn't even use wptserve so *.any.js and similar tests don't work there at all.

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Apr 4, 2018

So I guess the question is really: Should we add a second, more explicit lint to disallow *.any.js and *.window.js?

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Apr 4, 2018

re: supporting it in the CSS build, is it sufficient to output <link rel="help" href="url"> tags in the generated HTML?

re: not allowing *.any.js etc. I'm not fussed; it essentially solves the MISSING-LINK problem via forcing to an html version for which the lint can be appeased. Of course, that makes this PR redundant. Feel free to send a PR.

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Apr 5, 2018

Closing, as this approach opens a can of worms. Better to improve the docs and remove the 2 .any.js whitelisted items in favour of .html

@lukebjerring lukebjerring deleted the lukebjerring:lint-meta-spec-link branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.